[alsa-devel] atmel_ssc_dai.c, use of dai->id
Hello,
I am trying to use SSC1 (not SSC0 which might work) on a SAMA5D4-Xplained board (4.1 kernel, but close to mainline)
c706f2e5 ASoC: atmel_ssc_dai: distinguish the different SSC fixes an issue with cpu_dai id being always 0, while the ssc id should have been used (or the platform_device id)
I think there is a remaining issue with DMA parameters in atmel_ssc_startup():
line 324: dma_params = &ssc_dma_params[dai->id][dir];
I think it should be dma_params = &ssc_dma_params[pdev->id][dir];
I am new to this platform, please comment I can submit a formal patch later-on of course
thanks, regards, p.
On 7/5/2016 03:00, Peter Meerwald-Stadler wrote:
Hello,
I am trying to use SSC1 (not SSC0 which might work) on a SAMA5D4-Xplained board (4.1 kernel, but close to mainline)
c706f2e5 ASoC: atmel_ssc_dai: distinguish the different SSC fixes an issue with cpu_dai id being always 0, while the ssc id should have been used (or the platform_device id)
I think there is a remaining issue with DMA parameters in atmel_ssc_startup():
line 324: dma_params = &ssc_dma_params[dai->id][dir];
I think it should be dma_params = &ssc_dma_params[pdev->id][dir];
I am new to this platform, please comment I can submit a formal patch later-on of course
Hi Peter,
Yes, you are right. It should be fixed in atmel_ssc_startup(). Thank you.
thanks, regards, p.
participants (2)
-
Peter Meerwald-Stadler
-
Wu, Songjun