[alsa-devel] [PATCH 1/1] ARM: TLV320AIC23 SoC Audio Codec: Fix errors reported related to input routing signals.
From: dobatog dobatog@gmail.com
The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:
tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input
I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.
Tested on CM-510 (Compulab SoM Board).
Signed-off-by: dobatog dobatog@gmail.com --- sound/soc/codecs/tlv320aic23.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c index cc17e7e..891f3aa 100644 --- a/sound/soc/codecs/tlv320aic23.c +++ b/sound/soc/codecs/tlv320aic23.c @@ -174,10 +174,10 @@ static const struct snd_soc_dapm_route tlv320aic23_intercon[] = { {"ROUT", NULL, "Output Mixer"},
/* Inputs */ - {"Line Input", "NULL", "LLINEIN"}, - {"Line Input", "NULL", "RLINEIN"}, + {"Line Input", NULL, "LLINEIN"}, + {"Line Input", NULL, "RLINEIN"},
- {"Mic Input", "NULL", "MICIN"}, + {"Mic Input", NULL, "MICIN"},
/* input mux */ {"Capture Source", "Line", "Line Input"},
On Thu, Feb 26, 2015 at 2:32 PM, Gabriel Dobato dobatog@gmail.com wrote:
From: dobatog dobatog@gmail.com
The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:
tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input
I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.
Tested on CM-510 (Compulab SoM Board).
Tested-by: Max Filippov jcmvbkbc@gmail.com
Signed-off-by: dobatog dobatog@gmail.com
I believe you need to use your real name here and in the From: line.
On 02/26/2015 12:32 PM, Gabriel Dobato wrote:
From: dobatog dobatog@gmail.com
The following patch, based on stable v3.19, corrects the errors that are reported in the boot trace in reference to the Input Signals of the audio codec TLV320AIC23:
tlv320aic23-codec 1-001a: Control not supported for path LLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for LLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route LLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path RLINEIN -> [NULL] -> Line Input tlv320aic23-codec 1-001a: ASoC: no dapm match for RLINEIN --> NULL --> Line Input tlv320aic23-codec 1-001a: ASoC: Failed to add route RLINEIN -> NULL -> Line Input tlv320aic23-codec 1-001a: Control not supported for path MICIN -> [NULL] -> Mic Input tlv320aic23-codec 1-001a: ASoC: no dapm match for MICIN --> NULL --> Mic Input tlv320aic23-codec 1-001a: ASoC: Failed to add route MICIN -> NULL -> Mic Input
I am trying to set the sound system in a CM-510 (Compulab - SoM) based board with DT, using Simple-Card-Audio and the TLV320AIC23 audio codec included in the SoM . I faced this problem and thanks to the help of Sebastian Hesselbarth who noticed the possible error located in the structure snd_soc_dapm_route tlv320aic23_intercon[] , now errors are not reported.
Tested on CM-510 (Compulab SoM Board).
Signed-off-by: dobatog dobatog@gmail.com
Hi,
The patch itself looks good, but the commit message needs some work.
The subject line should be something like "ASoC: tlv320aic23: ..." to indicate that this is for the ASoC subsystem and the tlv320aic23 driver.
The commit message should be line-wrapped at around 76 characters.
Signed-off-by and From tag need to have your full name.
- Lars
participants (3)
-
Gabriel Dobato -
Lars-Peter Clausen -
Max Filippov