[alsa-devel] [PATCH] ASoC: rt5645: Rename HP control to Headphone
Use the standard name "Headphone" instead of "HP" for better userspace integration.
Signed-off-by: Nicolas Boichat drinkcat@chromium.org --- sound/soc/codecs/rt5645.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index be4d741..bc925f0 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -464,9 +464,9 @@ static const struct snd_kcontrol_new rt5645_snd_controls[] = { RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* Headphone Output Volume */ - SOC_DOUBLE("HP Channel Switch", RT5645_HP_VOL, + SOC_DOUBLE("Headphone Channel Switch", RT5645_HP_VOL, RT5645_VOL_L_SFT, RT5645_VOL_R_SFT, 1, 1), - SOC_DOUBLE_TLV("HP Playback Volume", RT5645_HP_VOL, + SOC_DOUBLE_TLV("Headphone Playback Volume", RT5645_HP_VOL, RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* OUTPUT Control */
-----Original Message----- From: Nicolas Boichat [mailto:drinkcat@chromium.org] Sent: Wednesday, May 13, 2015 4:15 PM To: alsa-devel@alsa-project.org Cc: Bard Liao; Oder Chiou; Koro Chen Subject: [PATCH] ASoC: rt5645: Rename HP control to Headphone
Use the standard name "Headphone" instead of "HP" for better userspace integration.
Signed-off-by: Nicolas Boichat drinkcat@chromium.org
Acked-by: Bard Liao bardliao@realtek.com
Should we send it to Mark Brown broonie@kernel.org?
------Please consider the environment before printing this e-mail.
On Wed, May 13, 2015 at 11:59:43AM +0000, Bard Liao wrote:
-----Original Message----- From: Nicolas Boichat [mailto:drinkcat@chromium.org] Sent: Wednesday, May 13, 2015 4:15 PM To: alsa-devel@alsa-project.org Cc: Bard Liao; Oder Chiou; Koro Chen Subject: [PATCH] ASoC: rt5645: Rename HP control to Headphone
Use the standard name "Headphone" instead of "HP" for better userspace integration.
Signed-off-by: Nicolas Boichat drinkcat@chromium.org
Acked-by: Bard Liao bardliao@realtek.com
Should we send it to Mark Brown broonie@kernel.org?
Yes, he is the maintainer that would apply it so the patch needs to be sent to him.
Thanks, Charles
Use the standard name "Headphone" instead of "HP" for better userspace integration.
Signed-off-by: Nicolas Boichat drinkcat@chromium.org Acked-by: Bard Liao bardliao@realtek.com ---
Resending without modification, adding Mark to CC list.
Thanks!
sound/soc/codecs/rt5645.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index be4d741..bc925f0 100644 --- a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -464,9 +464,9 @@ static const struct snd_kcontrol_new rt5645_snd_controls[] = { RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* Headphone Output Volume */ - SOC_DOUBLE("HP Channel Switch", RT5645_HP_VOL, + SOC_DOUBLE("Headphone Channel Switch", RT5645_HP_VOL, RT5645_VOL_L_SFT, RT5645_VOL_R_SFT, 1, 1), - SOC_DOUBLE_TLV("HP Playback Volume", RT5645_HP_VOL, + SOC_DOUBLE_TLV("Headphone Playback Volume", RT5645_HP_VOL, RT5645_L_VOL_SFT, RT5645_R_VOL_SFT, 39, 1, out_vol_tlv),
/* OUTPUT Control */
participants (4)
-
Bard Liao -
Charles Keepax -
Mark Brown -
Nicolas Boichat