[alsa-devel] Segfault in pulseaudio since Alsa 1.1.7
Hi,
Â
Since the upgrade to Alsa 1.1.7, I get a segfault at pulseaudio startup. This have been discussed and documented here : [1]https://www.linuxquestions.org/questions/slackware-14/current-fri-oc t-19-puseaudio-segfauts-4175640773/
Â
It seems that I found the origin of the bug : reverting these 2 commits fixes the problem : [2]http://git.alsa-project.org/?p=alsa-...792dc809c908cc [3]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7
Then no more segfault in pulseaudio when accessing the USB soundcard.
Â
Please could you fix it ?
Â
Regards
jp
References
Visible links 1. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 2. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff... 3. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd...
Hidden links: 4. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus...
I have narrowed to the simpler patch below : Â Quote: diff -rNaud alsa-plugins-1.1.7/a52/pcm_a52.c alsa-plugins-1.1.7-new/a52/pcm_a52.c --- alsa-plugins-1.1.7/a52/pcm_a52.c 2018-10-16 14:00:22.000000000 +0200 +++ alsa-plugins-1.1.7-new/a52/pcm_a52.c 2018-10-23 08:35:15.699830909 +0200 @@ -978,7 +978,8 @@ if ((err = a52_set_hw_constraint(rec)) < 0) { snd_pcm_ioplug_delete(&rec->io); - goto error; + free(rec); + return err; } *pcmp = rec->io.pcm; Â
Â
22.10.2018, 23:30, "Hyperion" h1p8r10n@yandex.com:
   Hi,    Â    Since the upgrade to Alsa 1.1.7, I get a segfault at pulseaudio    startup. This have been discussed and documented here :    [1][1]https://www.linuxquestions.org/questions/slackware-14/cu rrent-fri-oc    t-19-puseaudio-segfauts-4175640773/    Â    It seems that I found the origin of the bug : reverting these 2 commits    fixes the problem :    [2][2]http://git.alsa-project.org/?p=alsa-...792dc809c908cc    [3][3]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7    Then no more segfault in pulseaudio when accessing the USB soundcard.    Â    Please could you fix it ?    Â    Regards    jp References    Visible links    1. [4]https://www.linuxquestions.org/questions/slackware-14/current-fri -oct-19-puseaudio-segfauts-4175640773/    2. [5]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc 3f5d51062ff438780e568995792dc809c908cc    3. [6]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b 996865126dd559ef186002e45dc6e1594291e7    Hidden links:    4. [7]https://www.linuxquestions.org/questions/slackware-14/current-fri -oct-19-puseaudio-segfauts-4175640773/ _______________________________________________ Alsa-devel mailing list [8]Alsa-devel@alsa-project.org [9]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
References
1. https://www.linuxquestions.org/questions/slackware-14/current-fri-oc 2. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 3. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 4. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 5. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff... 6. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd... 7. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 8. mailto:Alsa-devel@alsa-project.org 9. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Dne 23.10.2018 v 08:43 Hyperion napsal(a):
I have narrowed to the simpler patch below : Â Quote: diff -rNaud alsa-plugins-1.1.7/a52/pcm_a52.c alsa-plugins-1.1.7-new/a52/pcm_a52.c --- alsa-plugins-1.1.7/a52/pcm_a52.c 2018-10-16 14:00:22.000000000 +0200 +++ alsa-plugins-1.1.7-new/a52/pcm_a52.c 2018-10-23 08:35:15.699830909 +0200 @@ -978,7 +978,8 @@ if ((err = a52_set_hw_constraint(rec)) < 0) { snd_pcm_ioplug_delete(&rec->io);
- goto error;
- free(rec);
- return err;
} *pcmp = rec->io.pcm; Â
It does not appear like a correct change, because rec->slave is initialized in previous lines (snd_pcm_open calls). Could you inspect rec->slave in gdb ?
Jaroslav
Â
22.10.2018, 23:30, "Hyperion" h1p8r10n@yandex.com:
   Hi,    Â    Since the upgrade to Alsa 1.1.7, I get a segfault at pulseaudio    startup. This have been discussed and documented here :    [1][1]https://www.linuxquestions.org/questions/slackware-14/cu rrent-fri-oc    t-19-puseaudio-segfauts-4175640773/    Â    It seems that I found the origin of the bug : reverting these 2 commits    fixes the problem :    [2][2]http://git.alsa-project.org/?p=alsa-...792dc809c908cc    [3][3]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7    Then no more segfault in pulseaudio when accessing the USB soundcard.    Â    Please could you fix it ?    Â    Regards    jp References    Visible links    1. [4]https://www.linuxquestions.org/questions/slackware-14/current-fri -oct-19-puseaudio-segfauts-4175640773/    2. [5]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc 3f5d51062ff438780e568995792dc809c908cc    3. [6]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b 996865126dd559ef186002e45dc6e1594291e7    Hidden links:    4. [7]https://www.linuxquestions.org/questions/slackware-14/current-fri -oct-19-puseaudio-segfauts-4175640773/ _______________________________________________ Alsa-devel mailing list [8]Alsa-devel@alsa-project.org [9]http://mailman.alsa-project.org/mailman/listinfo/alsa-develReferences
- https://www.linuxquestions.org/questions/slackware-14/current-fri-oc
- http://git.alsa-project.org/?p=alsa-...792dc809c908cc
- http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7
- https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus...
- http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff...
- http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd...
- https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus...
- mailto:Alsa-devel@alsa-project.org
- http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Sorry, I have no more time to spend debugging :(
Â
Thus I guess that the true alsa maintainers will be much more efficient than me (I'm just doing quick and dirty hacking here).
Â
My XMOS USB soundcard now works with this workaround, please could you take a look at traces I posted in the discussion on LQ.org ?
Â
All the best
JP
Â
23.10.2018, 08:53, "Jaroslav Kysela" perex@perex.cz:
Dne 23.10.2018 v 08:43 Hyperion napsal(a):
    I have narrowed to the simpler patch below :     Â     Quote:     diff -rNaud alsa-plugins-1.1.7/a52/pcm_a52.c     alsa-plugins-1.1.7-new/a52/pcm_a52.c     --- alsa-plugins-1.1.7/a52/pcm_a52.c 2018-10-16 14:00:22.000000000     +0200     +++ alsa-plugins-1.1.7-new/a52/pcm_a52.c 2018-10-23 08:35:15.699830909     +0200     @@ -978,7 +978,8 @@     if ((err = a52_set_hw_constraint(rec)) < 0) {     snd_pcm_ioplug_delete(&rec->io);     - goto error;     + free(rec);     + return err;     }     *pcmp = rec->io.pcm;     Â
It does not appear like a correct change, because rec->slave is initialized in previous lines (snd_pcm_open calls). Could you inspect rec->slave in gdb ?                                                 Jaroslav  Â
    Â     22.10.2018, 23:30, "Hyperion" <[1]h1p8r10n@yandex.com>:       Â Â Â Hi,       Â Â Â Â       Â Â Â Since the upgrade to Alsa 1.1.7, I get a segfault at       pulseaudio       Â Â Â startup. This have been discussed and documented here :       Â Â Â [1][1][2]https://www.linuxquestions.org/questions/slackware-14/cu       rrent-fri-oc       Â Â Â t-19-puseaudio-segfauts-4175640773/       Â Â Â Â       Â Â Â It seems that I found the origin of the bug : reverting these       2 commits       Â Â Â fixes the problem :       Â Â Â [2][2][3]http://git.alsa-project.org/?p=alsa-...792dc809c908cc       Â Â Â [3][3][4]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7       Â Â Â Then no more segfault in pulseaudio when accessing the USB       soundcard.       Â Â Â Â       Â Â Â Please could you fix it ?       Â Â Â Â       Â Â Â Regards       Â Â Â jp       References       Â Â Â Visible links       Â Â Â 1.       [4][5]https://www.linuxquestions.org/questions/slackware -14/current-fri       -oct-19-puseaudio-segfauts-4175640773/       Â Â Â 2.       [5][6]http://git.alsa-project.org/?p=alsa-plugins.git;a= commitdiff;h=fc       3f5d51062ff438780e568995792dc809c908cc       Â Â Â 3.       [6][7]http://git.alsa-project.org/?p=alsa-plugins.git;a= commitdiff;h=6b       996865126dd559ef186002e45dc6e1594291e7       Â Â Â Hidden links:       Â Â Â 4.       [7][8]https://www.linuxquestions.org/questions/slackware -14/current-fri       -oct-19-puseaudio-segfauts-4175640773/       _______________________________________________       Alsa-devel mailing list       [8][9]Alsa-devel@alsa-project.org       [9][10]http://mailman.alsa-project.org/mailman/listinfo/ alsa-devel  References     1. [11]https://www.linuxquestions.org/questions/slackware-14/current-fr i-oc     2. [12]http://git.alsa-project.org/?p=alsa-...792dc809c908cc     3. [13]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7     4. [14]https://www.linuxquestions.org/questions/slackware-14/current-fr i-oct-19-puseaudio-segfauts-4175640773/     5. [15]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=f c3f5d51062ff438780e568995792dc809c908cc     6. [16]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6 b996865126dd559ef186002e45dc6e1594291e7     7. [17]https://www.linuxquestions.org/questions/slackware-14/current-fr i-oct-19-puseaudio-segfauts-4175640773/     8. mailto:[18]Alsa-devel@alsa-project.org     9. [19]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel  _______________________________________________  Alsa-devel mailing list  [20]Alsa-devel@alsa-project.org  [21]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel Â
 -- Jaroslav Kysela <[22]perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc. _______________________________________________ Alsa-devel mailing list [23]Alsa-devel@alsa-project.org [24]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
References
1. mailto:h1p8r10n@yandex.com 2. https://www.linuxquestions.org/questions/slackware-14/cu 3. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 4. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 5. https://www.linuxquestions.org/questions/slackware-14/current-fri 6. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc 7. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b 8. https://www.linuxquestions.org/questions/slackware-14/current-fri 9. mailto:Alsa-devel@alsa-project.org 10. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 11. https://www.linuxquestions.org/questions/slackware-14/current-fri-oc 12. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 13. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 14. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 15. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff... 16. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd... 17. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 18. mailto:Alsa-devel@alsa-project.org 19. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 20. mailto:Alsa-devel@alsa-project.org 21. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 22. mailto:perex@perex.cz 23. mailto:Alsa-devel@alsa-project.org 24. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Dne 23.10.2018 v 09:06 Hyperion napsal(a):
Sorry, I have no more time to spend debugging :( Thus I guess that the true alsa maintainers will be much more efficient than me (I'm just doing quick and dirty hacking here). My XMOS USB soundcard now works with this workaround, please could you take a look at traces I posted in the discussion on LQ.org ?
Here is the better fix:
http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=a4e7e1282c57a...
There was really a double pcm free, because:
snd_pcm_ioplug_delete -> snd_pcm_close -> snd_pcm_ioplug_close -> a52_close() -> snd_pcm_close(rec->slave)
Jaroslav
All the best JP 23.10.2018, 08:53, "Jaroslav Kysela" perex@perex.cz:
Dne 23.10.2018 v 08:43 Hyperion napsal(a):
I have narrowed to the simpler patch below : Â Quote: diff -rNaud alsa-plugins-1.1.7/a52/pcm_a52.c alsa-plugins-1.1.7-new/a52/pcm_a52.c --- alsa-plugins-1.1.7/a52/pcm_a52.c 2018-10-16 14:00:22.000000000 +0200 +++ alsa-plugins-1.1.7-new/a52/pcm_a52.c 2018-10-23 08:35:15.699830909 +0200 @@ -978,7 +978,8 @@ if ((err = a52_set_hw_constraint(rec)) < 0) { snd_pcm_ioplug_delete(&rec->io); - goto error; + free(rec); + return err; } *pcmp = rec->io.pcm; ÂIt does not appear like a correct change, because rec->slave is initialized in previous lines (snd_pcm_open calls). Could you inspect rec->slave in gdb ?
Jaroslav
 22.10.2018, 23:30, "Hyperion" <h1p8r10n@yandex.com <mailto:h1p8r10n@yandex.com>>:    Hi,    Â    Since the upgrade to Alsa 1.1.7, I get a segfault at pulseaudio    startup. This have been discussed and documented here :    [1][1]https://www.linuxquestions.org/questions/slackware-14/cu rrent-fri-oc    t-19-puseaudio-segfauts-4175640773/    Â    It seems that I found the origin of the bug : reverting these 2 commits    fixes the problem :    [2][2]http://git.alsa-project.org/?p=alsa-...792dc809c908cc    [3][3]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7    Then no more segfault in pulseaudio when accessing the USB soundcard.    Â    Please could you fix it ?    Â    Regards    jp References    Visible links    1. [4]https://www.linuxquestions.org/questions/slackware-14/current-fri -oct-19-puseaudio-segfauts-4175640773/    2. [5]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc 3f5d51062ff438780e568995792dc809c908cc    3. [6]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b 996865126dd559ef186002e45dc6e1594291e7    Hidden links:    4. [7]https://www.linuxquestions.org/questions/slackware-14/current-fri -oct-19-puseaudio-segfauts-4175640773/ _______________________________________________ Alsa-devel mailing list [8]Alsa-devel@alsa-project.org <mailto:Alsa-devel@alsa-project.org> [9]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel References 1. https://www.linuxquestions.org/questions/slackware-14/current-fri-oc 2. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 3. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 4. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-puseaudio-segfauts-4175640773/ 5. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff438780e568995792dc809c908cc 6. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd559ef186002e45dc6e1594291e7 7. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-puseaudio-segfauts-4175640773/ 8. mailto:Alsa-devel@alsa-project.org <mailto:Alsa-devel@alsa-project.org> 9. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org <mailto:Alsa-devel@alsa-project.org> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel-- Jaroslav Kysela <perex@perex.cz mailto:perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org mailto:Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Great !! looks like the real fix (I'm going to rebuild my version of alsa-plugins with it and let you know).
Â
Thanks
Â
JP
Â
23.10.2018, 09:37, "Jaroslav Kysela" perex@perex.cz:
Dne 23.10.2018 v 09:06 Hyperion napsal(a):
 Sorry, I have no more time to spend debugging :(    Thus I guess that the true alsa maintainers will be much more efficient  than me (I'm just doing quick and dirty hacking here).    My XMOS USB soundcard now works with this workaround, please could you  take a look at traces I posted in the discussion on LQ.org ?
Here is the better fix: [1]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=a4 e7e1282c57a2f4e83afe9a4008042d8b4c5bb9 There was really a double pcm free, because: Â Â snd_pcm_ioplug_delete -> Â Â Â Â snd_pcm_close -> Â Â Â Â Â Â snd_pcm_ioplug_close -> Â Â Â Â Â Â Â Â a52_close() -> Â Â Â Â Â Â Â Â Â Â snd_pcm_close(rec->slave) Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Jaroslav Â
   All the best  JP    23.10.2018, 08:53, "Jaroslav Kysela" <[2]perex@perex.cz>: Â
 Dne 23.10.2018 v 08:43 Hyperion napsal(a):          I have narrowed to the simpler patch below :          Â          Quote:          diff -rNaud alsa-plugins-1.1.7/a52/pcm_a52.c          alsa-plugins-1.1.7-new/a52/pcm_a52.c          --- alsa-plugins-1.1.7/a52/pcm_a52.c 2018-10-16 14:00:22.000000000          +0200          +++ alsa-plugins-1.1.7-new/a52/pcm_a52.c 2018-10-23      08:35:15.699830909          +0200          @@ -978,7 +978,8 @@          if ((err = a52_set_hw_constraint(rec)) < 0) {          snd_pcm_ioplug_delete(&rec->io);          - goto error;          + free(rec);          + return err;          }          *pcmp = rec->io.pcm;          Â  It does not appear like a correct change, because rec->slave is  initialized in previous lines (snd_pcm_open calls). Could you inspect  rec->slave in gdb ?                                                  Jaroslav              Â          22.10.2018, 23:30, "Hyperion" <[3]h1p8r10n@yandex.com      mailto:[4]h1p8r10n@yandex.com>:            Â   Hi,            Â   Â            Â   Since the upgrade to Alsa 1.1.7, I get a segfault at            pulseaudio            Â   startup. This have been discussed and documented here :            Â        [1][1][5]https://www.linuxquestions.org/questions/slackwar e-14/cu            rrent-fri-oc            Â   t-19-puseaudio-segfauts-4175640773/            Â   Â            Â   It seems that I found the origin of the bug :      reverting these            2 commits            Â   fixes the problem :            Â        [2][2][6]http://git.alsa-project.org/?p=alsa-...792dc809c9 08cc            Â        [3][3][7]http://git.alsa-project.org/?p=alsa-...5dc6e15942 91e7            Â   Then no more segfault in pulseaudio when accessing the USB            soundcard.            Â   Â            Â   Please could you fix it ?            Â   Â            Â   Regards            Â   jp            References            Â   Visible links            Â   1.            [4][8]https://www.linuxquestions.org/questions /slackware-14/current-fri            -oct-19-puseaudio-segfauts-4175640773/            Â   2.            [5][9]http://git.alsa-project.org/?p=alsa-plug ins.git;a=commitdiff;h=fc            3f5d51062ff438780e568995792dc809c908cc            Â   3.            [6][10]http://git.alsa-project.org/?p=alsa-plu gins.git;a=commitdiff;h=6b            996865126dd559ef186002e45dc6e1594291e7            Â   Hidden links:            Â   4.            [7][11]https://www.linuxquestions.org/question s/slackware-14/current-fri            -oct-19-puseaudio-segfauts-4175640773/            ______________________________________________ _            Alsa-devel mailing list            [8][12]Alsa-devel@alsa-project.org      mailto:[13]Alsa-devel@alsa-project.org            [9][14]http://mailman.alsa-project.org/mailman /listinfo/alsa-devel       References          1.      [15]https://www.linuxquestions.org/questions/slackware-14/ current-fri-oc          2. [16]http://git.alsa-project.org/?p=alsa-...792dc809c908cc          3. [17]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7          4.      [18]https://www.linuxquestions.org/questions/slackware-14/ current-fri-oct-19-puseaudio-segfauts-4175640773/          5.      [19]http://git.alsa-project.org/?p=alsa-plugins.git;a=comm itdiff;h=fc3f5d51062ff438780e568995792dc809c908cc          6.      [20]http://git.alsa-project.org/?p=alsa-plugins.git;a=comm itdiff;h=6b996865126dd559ef186002e45dc6e1594291e7          7.      [21]https://www.linuxquestions.org/questions/slackware-14/ current-fri-oct-19-puseaudio-segfauts-4175640773/          8. mailto:[22]Alsa-devel@alsa-project.org      mailto:[23]Alsa-devel@alsa-project.org          9. [24]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel       _______________________________________________       Alsa-devel mailing list       [25]Alsa-devel@alsa-project.org mailto:[26]Alsa-devel@alsa-project.org       [27]http://mailman.alsa-project.org/mailman/listinfo/als a-devel          --  Jaroslav Kysela <[28]perex@perex.cz mailto:[29]perex@perex.cz>  Linux Sound Maintainer; ALSA Project; Red Hat, Inc.  _______________________________________________  Alsa-devel mailing list  [30]Alsa-devel@alsa-project.org mailto:[31]Alsa-devel@alsa-project.org  [32]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
 -- Jaroslav Kysela <[33]perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
References
1. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=a4e7e1282c57a... 2. mailto:perex@perex.cz 3. mailto:h1p8r10n@yandex.com 4. mailto:h1p8r10n@yandex.com 5. https://www.linuxquestions.org/questions/slackware-14/cu 6. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 7. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 8. https://www.linuxquestions.org/questions/slackware-14/current-fri 9. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc 10. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b 11. https://www.linuxquestions.org/questions/slackware-14/current-fri 12. mailto:Alsa-devel@alsa-project.org 13. mailto:Alsa-devel@alsa-project.org 14. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 15. https://www.linuxquestions.org/questions/slackware-14/current-fri-oc 16. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 17. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 18. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 19. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff... 20. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd... 21. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 22. mailto:Alsa-devel@alsa-project.org 23. mailto:Alsa-devel@alsa-project.org 24. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 25. mailto:Alsa-devel@alsa-project.org 26. mailto:Alsa-devel@alsa-project.org 27. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 28. mailto:perex@perex.cz 29. mailto:perex@perex.cz 30. mailto:Alsa-devel@alsa-project.org 31. mailto:Alsa-devel@alsa-project.org 32. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 33. mailto:perex@perex.cz
validated !
Â
23.10.2018, 19:17, "Hyperion" h1p8r10n@yandex.com:
   Great !! looks like the real fix (I'm going to rebuild my version of    alsa-plugins with it and let you know).    Â    Thanks    Â    JP    Â    23.10.2018, 09:37, "Jaroslav Kysela" <[1]perex@perex.cz>:      Dne 23.10.2018 v 09:06 Hyperion napsal(a):      Â Sorry, I have no more time to spend debugging :(      Â       Â Thus I guess that the true alsa maintainers will be much more      efficient      Â than me (I'm just doing quick and dirty hacking here).      Â       Â My XMOS USB soundcard now works with this workaround, please could      you      Â take a look at traces I posted in the discussion on LQ.org ?      Here is the better fix:      [1][2]http://git.alsa-project.org/?p=alsa-plugins.git;a=co mmitdiff;h=a4      e7e1282c57a2f4e83afe9a4008042d8b4c5bb9      There was really a double pcm free, because:      Â  snd_pcm_ioplug_delete ->      Â    snd_pcm_close ->      Â      snd_pcm_ioplug_close ->      Â        a52_close() ->      Â          snd_pcm_close(rec->slave)      Â                                       Â      Jaroslav      Â      Â       Â All the best      Â JP      Â       Â 23.10.2018, 08:53, "Jaroslav Kysela" <[2][3]perex@perex.cz>:      Â      Â Dne 23.10.2018 v 08:43 Hyperion napsal(a):      Â         I have narrowed to the simpler patch below :      Â         Â      Â         Quote:      Â         diff -rNaud alsa-plugins-1.1.7/a52/pcm_a52.c      Â         alsa-plugins-1.1.7-new/a52/pcm_a52.c      Â         --- alsa-plugins-1.1.7/a52/pcm_a52.c 2018-10-16      14:00:22.000000000      Â         +0200      Â         +++ alsa-plugins-1.1.7-new/a52/pcm_a52.c      2018-10-23      Â     08:35:15.699830909      Â         +0200      Â         @@ -978,7 +978,8 @@      Â         if ((err = a52_set_hw_constraint(rec)) < 0) {      Â         snd_pcm_ioplug_delete(&rec->io);      Â         - goto error;      Â         + free(rec);      Â         + return err;      Â         }      Â         *pcmp = rec->io.pcm;      Â         Â      Â It does not appear like a correct change, because rec->slave is      Â initialized in previous lines (snd_pcm_open calls). Could you      inspect      Â rec->slave in gdb ?      Â                                       Â               Jaroslav      Â       Â       Â         Â      Â         22.10.2018, 23:30, "Hyperion"      <[3][4]h1p8r10n@yandex.com      Â     mailto:[5][4]h1p8r10n@yandex.com>:      Â           Â Â Â Hi,      Â           Â Â Â Â      Â           Â Â Â Since the upgrade to Alsa 1.1.7, I      get a segfault at      Â           pulseaudio      Â           Â Â Â startup. This have been discussed and      documented here :      Â           Â Â Â      Â     [1][1][5][6]https://www.linuxquestions.org/questions/slackwar      e-14/cu      Â           rrent-fri-oc      Â           Â Â Â t-19-puseaudio-segfauts-4175640773/      Â           Â Â Â Â      Â           Â Â Â It seems that I found the origin of      the bug :      Â     reverting these      Â           2 commits      Â           Â Â Â fixes the problem :      Â           Â Â Â      Â     [2][2][6][7]http://git.alsa-project.org/?p=alsa-...792dc809c9      08cc      Â           Â Â Â      Â     [3][3][7][8]http://git.alsa-project.org/?p=alsa-...5dc6e15942      91e7      Â           Â Â Â Then no more segfault in pulseaudio      when accessing the USB      Â           soundcard.      Â           Â Â Â Â      Â           Â Â Â Please could you fix it ?      Â           Â Â Â Â      Â           Â Â Â Regards      Â           Â Â Â jp      Â           References      Â           Â Â Â Visible links      Â           Â Â Â 1.      Â           [4][8][9]https://www.linuxquestions.org/questions      /slackware-14/current-fri      Â           -oct-19-puseaudio-segfauts-4175640773/      Â           Â Â Â 2.      Â           [5][9][10]http://git.alsa-project.org/?p=alsa-plug      ins.git;a=commitdiff;h=fc      Â           3f5d51062ff438780e568995792dc809c908cc      Â           Â Â Â 3.      Â           [6][10][11]http://git.alsa-project.org/?p=alsa-plu      gins.git;a=commitdiff;h=6b      Â           996865126dd559ef186002e45dc6e1594291e7      Â           Â Â Â Hidden links:      Â           Â Â Â 4.      Â           [7][11][12]https://www.linuxquestions.org/question      s/slackware-14/current-fri      Â           -oct-19-puseaudio-segfauts-4175640773/      Â           ______________________________________________      _      Â           Alsa-devel mailing list      Â           [8][12][13]Alsa-devel@alsa-project.org      Â     mailto:[14][13]Alsa-devel@alsa-project.org      Â           [9][14][15]http://mailman.alsa-project.org/mailman      /listinfo/alsa-devel      Â      References      Â         1.      Â     [15][16]https://www.linuxquestions.org/questions/slackware-14/      current-fri-oc      Â         2.      [16][17]http://git.alsa-project.org/?p=alsa-...792dc809c90 8cc      Â         3.      [17][18]http://git.alsa-project.org/?p=alsa-...5dc6e159429 1e7      Â         4.      Â     [18][19]https://www.linuxquestions.org/questions/slackware-14/      current-fri-oct-19-puseaudio-segfauts-4175640773/      Â         5.      Â     [19][20]http://git.alsa-project.org/?p=alsa-plugins.git;a=comm      itdiff;h=fc3f5d51062ff438780e568995792dc809c908cc      Â         6.      Â     [20][21]http://git.alsa-project.org/?p=alsa-plugins.git;a=comm      itdiff;h=6b996865126dd559ef186002e45dc6e1594291e7      Â         7.      Â     [21][22]https://www.linuxquestions.org/questions/slackware-14/      current-fri-oct-19-puseaudio-segfauts-4175640773/      Â         8. mailto:[23][22]Alsa-devel@alsa-project.org      Â     mailto:[24][23]Alsa-devel@alsa-project.org      Â         9.      [24][25]http://mailman.alsa-project.org/mailman/listinfo/a lsa-devel      Â      _______________________________________________      Â      Alsa-devel mailing list      Â      [25][26]Alsa-devel@alsa-project.org      mailto:[27][26]Alsa-devel@alsa-project.org      Â      [27][28]http://mailman.alsa-project.org/mailman/listinfo/als      a-devel      Â           Â       Â --      Â Jaroslav Kysela <[28][29]perex@perex.cz mailto:[30][29]perex@perex.cz>      Â Linux Sound Maintainer; ALSA Project; Red Hat, Inc.      Â _______________________________________________      Â Alsa-devel mailing list      Â [30][31]Alsa-devel@alsa-project.org      mailto:[32][31]Alsa-devel@alsa-project.org      Â [32][33]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel      Â      --      Jaroslav Kysela <[33][34]perex@perex.cz>      Linux Sound Maintainer; ALSA Project; Red Hat, Inc. References    1. [35]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=a 4e7e1282c57a2f4e83afe9a4008042d8b4c5bb9    2. mailto:[36]perex@perex.cz    3. mailto:[37]h1p8r10n@yandex.com    4. mailto:[38]h1p8r10n@yandex.com    5. [39]https://www.linuxquestions.org/questions/slackware-14/cu    6. [40]http://git.alsa-project.org/?p=alsa-...792dc809c908cc    7. [41]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7    8. [42]https://www.linuxquestions.org/questions/slackware-14/current-fr i    9. [43]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=f c   10. [44]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6 b   11. [45]https://www.linuxquestions.org/questions/slackware-14/current-fr i   12. mailto:[46]Alsa-devel@alsa-project.org   13. mailto:[47]Alsa-devel@alsa-project.org   14. [48]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel   15. [49]https://www.linuxquestions.org/questions/slackware-14/current-fr i-oc   16. [50]http://git.alsa-project.org/?p=alsa-...792dc809c908cc   17. [51]http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7   18. [52]https://www.linuxquestions.org/questions/slackware-14/current-fr i-oct-19-puseaudio-segfauts-4175640773/   19. [53]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=f c3f5d51062ff438780e568995792dc809c908cc   20. [54]http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6 b996865126dd559ef186002e45dc6e1594291e7   21. [55]https://www.linuxquestions.org/questions/slackware-14/current-fr i-oct-19-puseaudio-segfauts-4175640773/   22. mailto:[56]Alsa-devel@alsa-project.org   23. mailto:[57]Alsa-devel@alsa-project.org   24. [58]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel   25. mailto:[59]Alsa-devel@alsa-project.org   26. mailto:[60]Alsa-devel@alsa-project.org   27. [61]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel   28. mailto:[62]perex@perex.cz   29. mailto:[63]perex@perex.cz   30. mailto:[64]Alsa-devel@alsa-project.org   31. mailto:[65]Alsa-devel@alsa-project.org   32. [66]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel   33. mailto:[67]perex@perex.cz _______________________________________________ Alsa-devel mailing list [68]Alsa-devel@alsa-project.org [69]http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
References
1. mailto:perex@perex.cz 2. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=a4 3. mailto:perex@perex.cz 4. mailto:h1p8r10n@yandex.com 5. mailto:[4]h1p8r10n@yandex.com 6. https://www.linuxquestions.org/questions/slackwar 7. http://git.alsa-project.org/?p=alsa-...792dc809c9 8. http://git.alsa-project.org/?p=alsa-...5dc6e15942 9. https://www.linuxquestions.org/questions 10. http://git.alsa-project.org/?p=alsa-plug 11. http://git.alsa-project.org/?p=alsa-plu 12. https://www.linuxquestions.org/question 13. mailto:Alsa-devel@alsa-project.org 14. mailto:[13]Alsa-devel@alsa-project.org 15. http://mailman.alsa-project.org/mailman 16. https://www.linuxquestions.org/questions/slackware-14/ 17. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 18. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 19. https://www.linuxquestions.org/questions/slackware-14/ 20. http://git.alsa-project.org/?p=alsa-plugins.git;a=comm 21. http://git.alsa-project.org/?p=alsa-plugins.git;a=comm 22. https://www.linuxquestions.org/questions/slackware-14/ 23. mailto:[22]Alsa-devel@alsa-project.org 24. mailto:[23]Alsa-devel@alsa-project.org 25. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 26. mailto:Alsa-devel@alsa-project.org 27. mailto:[26]Alsa-devel@alsa-project.org 28. http://mailman.alsa-project.org/mailman/listinfo/als 29. mailto:perex@perex.cz 30. mailto:[29]perex@perex.cz 31. mailto:Alsa-devel@alsa-project.org 32. mailto:[31]Alsa-devel@alsa-project.org 33. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 34. mailto:perex@perex.cz 35. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=a4e7e1282c57a... 36. mailto:perex@perex.cz 37. mailto:h1p8r10n@yandex.com 38. mailto:h1p8r10n@yandex.com 39. https://www.linuxquestions.org/questions/slackware-14/cu 40. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 41. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 42. https://www.linuxquestions.org/questions/slackware-14/current-fri 43. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc 44. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b 45. https://www.linuxquestions.org/questions/slackware-14/current-fri 46. mailto:Alsa-devel@alsa-project.org 47. mailto:Alsa-devel@alsa-project.org 48. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 49. https://www.linuxquestions.org/questions/slackware-14/current-fri-oc 50. http://git.alsa-project.org/?p=alsa-...792dc809c908cc 51. http://git.alsa-project.org/?p=alsa-...5dc6e1594291e7 52. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 53. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=fc3f5d51062ff... 54. http://git.alsa-project.org/?p=alsa-plugins.git;a=commitdiff;h=6b996865126dd... 55. https://www.linuxquestions.org/questions/slackware-14/current-fri-oct-19-pus... 56. mailto:Alsa-devel@alsa-project.org 57. mailto:Alsa-devel@alsa-project.org 58. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 59. mailto:Alsa-devel@alsa-project.org 60. mailto:Alsa-devel@alsa-project.org 61. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 62. mailto:perex@perex.cz 63. mailto:perex@perex.cz 64. mailto:Alsa-devel@alsa-project.org 65. mailto:Alsa-devel@alsa-project.org 66. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel 67. mailto:perex@perex.cz 68. mailto:Alsa-devel@alsa-project.org 69. http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
participants (2)
-
Hyperion -
Jaroslav Kysela