[alsa-devel] [PATCH] ALSA: oxygen: Xonar DG(X): make model_xonar_dg const
Make this const as it not modified anywhere. It is only used during a copy operation. Also, add const to the declaration in header.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com --- sound/pci/oxygen/xonar_dg.h | 2 +- sound/pci/oxygen/xonar_dg_mixer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/oxygen/xonar_dg.h b/sound/pci/oxygen/xonar_dg.h index d461df3..5a07cda 100644 --- a/sound/pci/oxygen/xonar_dg.h +++ b/sound/pci/oxygen/xonar_dg.h @@ -51,6 +51,6 @@ void dump_cs4245_registers(struct oxygen *chip, void dg_resume(struct oxygen *chip); void dg_cleanup(struct oxygen *chip);
-extern struct oxygen_model model_xonar_dg; +extern const struct oxygen_model model_xonar_dg;
#endif diff --git a/sound/pci/oxygen/xonar_dg_mixer.c b/sound/pci/oxygen/xonar_dg_mixer.c index b885dac..d22fbe8 100644 --- a/sound/pci/oxygen/xonar_dg_mixer.c +++ b/sound/pci/oxygen/xonar_dg_mixer.c @@ -449,7 +449,7 @@ static int dg_mixer_init(struct oxygen *chip) return 0; }
-struct oxygen_model model_xonar_dg = { +const struct oxygen_model model_xonar_dg = { .longname = "C-Media Oxygen HD Audio", .chip = "CMI8786", .init = dg_init,
Bhumika Goyal wrote:
Make this const as it not modified anywhere. It is only used during a copy operation. Also, add const to the declaration in header.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
Acked-by: Clemens Ladisch clemens@ladisch.de
sound/pci/oxygen/xonar_dg.h | 2 +- sound/pci/oxygen/xonar_dg_mixer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/pci/oxygen/xonar_dg.h b/sound/pci/oxygen/xonar_dg.h index d461df3..5a07cda 100644 --- a/sound/pci/oxygen/xonar_dg.h +++ b/sound/pci/oxygen/xonar_dg.h @@ -51,6 +51,6 @@ void dump_cs4245_registers(struct oxygen *chip, void dg_resume(struct oxygen *chip); void dg_cleanup(struct oxygen *chip);
-extern struct oxygen_model model_xonar_dg; +extern const struct oxygen_model model_xonar_dg;
#endif diff --git a/sound/pci/oxygen/xonar_dg_mixer.c b/sound/pci/oxygen/xonar_dg_mixer.c index b885dac..d22fbe8 100644 --- a/sound/pci/oxygen/xonar_dg_mixer.c +++ b/sound/pci/oxygen/xonar_dg_mixer.c @@ -449,7 +449,7 @@ static int dg_mixer_init(struct oxygen *chip) return 0; }
-struct oxygen_model model_xonar_dg = { +const struct oxygen_model model_xonar_dg = { .longname = "C-Media Oxygen HD Audio", .chip = "CMI8786", .init = dg_init,
On Thu, 14 Sep 2017 16:04:15 +0200, Bhumika Goyal wrote:
Make this const as it not modified anywhere. It is only used during a copy operation. Also, add const to the declaration in header.
Signed-off-by: Bhumika Goyal bhumirks@gmail.com
Applied, thanks.
Takashi
participants (3)
-
Bhumika Goyal
-
Clemens Ladisch
-
Takashi Iwai