[alsa-devel] [PATCH -next] ASoC: tegra20-ac97: fix error return code in tegra20_ac97_platform_probe()
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fix to return -ENODEV instead of 0 when no GPIO supplied in tegra20_ac97_platform_probe().
Signed-off-by: Wei Yongjun yongjun_wei@trendmicro.com.cn --- sound/soc/tegra/tegra20_ac97.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c index d8b98d7..3ea9738 100644 --- a/sound/soc/tegra/tegra20_ac97.c +++ b/sound/soc/tegra/tegra20_ac97.c @@ -358,6 +358,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) } } else { dev_err(&pdev->dev, "no codec-reset GPIO supplied\n"); + ret = -ENODEV; goto err_clk_put; }
@@ -365,6 +366,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) "nvidia,codec-sync-gpio", 0); if (!gpio_is_valid(ac97->sync_gpio)) { dev_err(&pdev->dev, "no codec-sync GPIO supplied\n"); + ret = -ENODEV; goto err_clk_put; }
On 12/13/2013 10:15 PM, Wei Yongjun wrote:
From: Wei Yongjun yongjun_wei@trendmicro.com.cn
Fix to return -ENODEV instead of 0 when no GPIO supplied in tegra20_ac97_platform_probe().
diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c
@@ -358,6 +358,7 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) } } else { dev_err(&pdev->dev, "no codec-reset GPIO supplied\n");
ret = -ENODEV;
This would be better as:
ret = ac97->reset_gpio;
Since that will propagate the exact error code (and incidentally, deferred probe will work correctly then).
if (!gpio_is_valid(ac97->sync_gpio)) { dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
ret = -ENODEV;
Similarly here,
ret = ac97->sync_gpio;
participants (2)
-
Stephen Warren
-
Wei Yongjun