Re: [alsa-devel] conexant alsa patch
On Tue, 2007-08-28 at 15:20 +0200, Takashi Iwai wrote:
At Tue, 28 Aug 2007 00:27:39 +0000, Hirakendu Das wrote:
Hi.
This regarding the conexant alsa patches authored by you. Firstly, thanks for the drivers :). Just wanted to say that if you can kindly look at the following minor issue. The master volume control in any mixer frontend (alsamixer or kmix etc) doesn't work in the latest patches. It used to work in the old patches. Strangely and thankfully, just changing the references of "Master Playback Volume" and "Master Playback Switch" in the file patch_conexant.c to simply "Playback Volume" and "Playback Switch" as in the old patch seems to make it work again as earlier. It works for me on my hp dv5000t notebook with conexant 5047. Could you just look into if its the case for all others. (Please see the attachments for details.) (Its of a bit of cosmetic value for me, as without it, I can't control volume using my notebook buttons.) PS : Is it true for other sound codecs too ?
Can you try to build from HG tree? Then you can trace exactly which commit breaks by bisecting the commits.
thanks,
Takashi
Preliminary tests against the 2.6.22 (alsa driver 1.0.14) breaks the automute on my test board (for some reason - still looking at this). I will also try against the tip to see if there are other major issues.
On Tue, 2007-08-28 at 09:17 -0700, Tobin Davis wrote:
On Tue, 2007-08-28 at 15:20 +0200, Takashi Iwai wrote:
At Tue, 28 Aug 2007 00:27:39 +0000, Hirakendu Das wrote:
Hi.
This regarding the conexant alsa patches authored by you. Firstly, thanks for the drivers :). Just wanted to say that if you can kindly look at the following minor issue. The master volume control in any mixer frontend (alsamixer or kmix etc) doesn't work in the latest patches. It used to work in the old patches. Strangely and thankfully, just changing the references of "Master Playback Volume" and "Master Playback Switch" in the file patch_conexant.c to simply "Playback Volume" and "Playback Switch" as in the old patch seems to make it work again as earlier. It works for me on my hp dv5000t notebook with conexant 5047. Could you just look into if its the case for all others. (Please see the attachments for details.) (Its of a bit of cosmetic value for me, as without it, I can't control volume using my notebook buttons.) PS : Is it true for other sound codecs too ?
Can you try to build from HG tree? Then you can trace exactly which commit breaks by bisecting the commits.
thanks,
Takashi
Preliminary tests against the 2.6.22 (alsa driver 1.0.14) breaks the automute on my test board (for some reason - still looking at this). I will also try against the tip to see if there are other major issues.
Further testing against the tip does indeed break automute on my 5045 test board. I don't have any way of testing the 5047. I also looked over the patch, along with the original file, and it appears to be an older version of the driver. Current drivers don't have a "Master Playback Volume" control of this type, as I replaced them with bind_master_vol functions. What version are you testing?
This patch does not cleanly apply to the tip as it stands.
participants (1)
-
Tobin Davis