[alsa-devel] [PATCH 1/2] ASoC: fsl: fsl_dma: Use true/false for boolean init
From: Fabio Estevam fabio.estevam@freescale.com
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan.
The semantic patch that makes this change is available in scripts/coccinelle/misc/boolinit.cocci.
More information about semantic patching is available at http://coccinelle.lip6.fr/
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- sound/soc/fsl/fsl_dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index 93d7e56..ccadefc 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -445,7 +445,7 @@ static int fsl_dma_open(struct snd_pcm_substream *substream) return ret; }
- dma->assigned = 1; + dma->assigned = true;
snd_pcm_set_runtime_buffer(substream, &substream->dma_buffer); snd_soc_set_runtime_hwparams(substream, &fsl_dma_hardware); @@ -814,7 +814,7 @@ static int fsl_dma_close(struct snd_pcm_substream *substream) substream->runtime->private_data = NULL; }
- dma->assigned = 0; + dma->assigned = false;
return 0; }
From: Fabio Estevam fabio.estevam@freescale.com
Simplify a trivial if-return sequence. Possibly combine with a preceding function call.
The semantic patch that makes this change is available in scripts/coccinelle/misc/simple_return.cocci.
More information about semantic patching is available at http://coccinelle.lip6.fr/
Signed-off-by: Fabio Estevam fabio.estevam@freescale.com --- sound/soc/fsl/imx-mc13783.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/sound/soc/fsl/imx-mc13783.c b/sound/soc/fsl/imx-mc13783.c index 9e6493d..bb04590 100644 --- a/sound/soc/fsl/imx-mc13783.c +++ b/sound/soc/fsl/imx-mc13783.c @@ -45,11 +45,7 @@ static int imx_mc13783_hifi_hw_params(struct snd_pcm_substream *substream, if (ret) return ret;
- ret = snd_soc_dai_set_tdm_slot(cpu_dai, 0x3, 0x3, 2, 16); - if (ret) - return ret; - - return 0; + return snd_soc_dai_set_tdm_slot(cpu_dai, 0x3, 0x3, 2, 16); }
static struct snd_soc_ops imx_mc13783_hifi_ops = {
Fabio Estevam wrote:
From: Fabio Estevamfabio.estevam@freescale.com
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan.
The semantic patch that makes this change is available in scripts/coccinelle/misc/boolinit.cocci.
More information about semantic patching is available at http://coccinelle.lip6.fr/
Signed-off-by: Fabio Estevamfabio.estevam@freescale.com
Acked-by: Timur Tabi timur@tabi.org
On Sat, May 09, 2015 at 12:45:52PM -0300, Fabio Estevam wrote:
From: Fabio Estevam fabio.estevam@freescale.com
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan.
Applied both, thanks.
participants (3)
-
Fabio Estevam
-
Mark Brown
-
Timur Tabi