Il 31/07/23 08:42, Maso Huang (黃加竹) ha scritto:

On Fri, 2023-07-28 at 18:16 +0800, Maso Huang wrote:

...

On Fri, 2023-07-28 at 11:55 +0200, AngeloGioacchino Del Regno wrote:

...

Il 28/07/23 11:08, Maso Huang ha scritto:

...

Add document for mt7986 board with wm8960.

Signed-off-by: Maso Huang maso.huang@mediatek.com

.../sound/mediatek,mt7986-wm8960.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt7986- wm8960.yaml

diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt7986- wm8960.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt7986- wm8960.yaml new file mode 100644 index 000000000000..76394f7e5502 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mediatek,mt7986- wm8960.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id:

https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt7...

...

...

...

+$schema:

https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;...

...

...

...

+title: MediaTek MT7986 sound card with WM8960 codec

+maintainers:

• • Maso Huang maso.huang@mediatek.com

+properties:

• compatible:
• const: mediatek,mt7986-wm8960-machine

mediatek,mt7986-wm8960-sound looks better.

After which,

Reviewed-by: AngeloGioacchino Del Regno < angelogioacchino.delregno@collabora.com>

Hi Angelo,

Thanks for your review. I'll change the compatible to "mediatek,mt7986-wm8960-sound" in v4 patch.

Best regards, Maso

Hi Angelo,

One more question for this compatible.

The suffix "machine" means alsa machine driver for mt7986-wm8960. It might be better to use "machine" here.

Or you prefer "sound" than "machine"?

Best regards, Maso

I prefer "sound" because of consistency with other MediaTek machine driver compatible strings.

Regards, Angelo