[PATCH] ASoC: pxa: Drop empty platform remove function
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function.
Signed-off-by: Uwe Kleine-König u.kleine-koenig@pengutronix.de --- sound/soc/pxa/spitz.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c index 44303b6eb228..70442315f5c5 100644 --- a/sound/soc/pxa/spitz.c +++ b/sound/soc/pxa/spitz.c @@ -306,18 +306,12 @@ static int spitz_probe(struct platform_device *pdev) return ret; }
-static int spitz_remove(struct platform_device *pdev) -{ - return 0; -} - static struct platform_driver spitz_driver = { .driver = { .name = "spitz-audio", .pm = &snd_soc_pm_ops, }, .probe = spitz_probe, - .remove = spitz_remove, };
module_platform_driver(spitz_driver);
Hello,
On Mon, Dec 12, 2022 at 06:47:37PM +0100, Uwe Kleine-König wrote:
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function.
huh, I sent this out twice by mistake. I suggest you ignore this one and pick up the other one that is part of a series. (i.e. https://lore.kernel.org/alsa-devel/20221212205406.3771071-2-u.kleine-koenig@...).
Sorry for the duplicate, Uwe
On Mon, 12 Dec 2022 18:47:37 +0100, Uwe Kleine-König wrote:
A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: pxa: Drop empty platform remove function commit: e812aa458acf7c47f9f5d8e6c62177317a998263
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
participants (2)
-
Mark Brown -
Uwe Kleine-König