[alsa-devel] [PATCH] ALSA: pcm: constify attribute_group structures.
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/device.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 9781 240 8 10029 272d sound/core/pcm.o
File size After adding 'const': text data bss dec hex filename 9813 176 8 9997 270d sound/core/pcm.o
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com --- sound/core/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm.c b/sound/core/pcm.c index 8e980aa..ee3e8db0 100644 --- a/sound/core/pcm.c +++ b/sound/core/pcm.c @@ -1056,7 +1056,7 @@ static ssize_t show_pcm_class(struct device *dev, NULL };
-static struct attribute_group pcm_dev_attr_group = { +static const struct attribute_group pcm_dev_attr_group = { .attrs = pcm_dev_attrs, };
On Thu, 29 Jun 2017 12:32:56 +0200, Arvind Yadav wrote:
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/device.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 9781 240 8 10029 272d sound/core/pcm.o
File size After adding 'const': text data bss dec hex filename 9813 176 8 9997 270d sound/core/pcm.o
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com
Applied, thanks.
Takashi
participants (2)
-
Arvind Yadav
-
Takashi Iwai