[alsa-devel] [patch] ASoC: sigmadsp: uninitialized variable in sigmadsp_activate_ctrl()
The "changed" variable should be set to false at the start.
Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2') Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c index 34fdc40..d53680a 100644 --- a/sound/soc/codecs/sigmadsp.c +++ b/sound/soc/codecs/sigmadsp.c @@ -661,7 +661,8 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, struct snd_card *card = sigmadsp->component->card->snd_card; struct snd_kcontrol_volatile *vd; struct snd_ctl_elem_id id; - bool active, changed; + bool active; + bool changed = false;
active = sigmadsp_samplerate_valid(ctrl->samplerates, samplerate_mask);
On 11/26/2014 11:35 PM, Dan Carpenter wrote:
The "changed" variable should be set to false at the start.
Fixes: a35daac77a03 ('ASoC: sigmadsp: Add support for fw v2') Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Acked-by: Lars-Peter Clausen lars@metafoo.de
Thanks.
participants (3)
-
Dan Carpenter
-
Lars-Peter Clausen
-
Mark Brown