[PATCH] sound: fsl: add missing put_device() call in imx_hdmi_probe()
From: Wang Qing wangqing@vivo.com
of_find_device_by_node() takes a reference to the embedded struct device which needs to be dropped when error return.
Signed-off-by: Wang Qing wangqing@vivo.com --- sound/soc/fsl/imx-hdmi.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c index 929f69b..89fd8ad --- a/sound/soc/fsl/imx-hdmi.c +++ b/sound/soc/fsl/imx-hdmi.c @@ -125,6 +125,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) { + put_device(&cpu_pdev->dev); ret = -ENOMEM; goto fail; }
On Tue, Dec 07, 2021 at 04:56:58AM -0800, Qing Wang wrote:
From: Wang Qing wangqing@vivo.com
of_find_device_by_node() takes a reference to the embedded struct device which needs to be dropped when error return.
...
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) {
put_device(&cpu_pdev->dev);
If it's of_find_device_by_node() you need an of_node_put() since you're dropping a reference on the OF node.
participants (2)
-
Mark Brown
-
Qing Wang