[PATCH v2 0/2] Add support for QCM6490 and QCS6490
This patchset adds support for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Changes since v1: - Use existing sc8280xp machine driver instead of separate driver. - Modify qcs6490 compatible name as qcs6490-rb3gen2.
Mohammad Rafi Shaik (2): ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ sound/soc/qcom/sc8280xp.c | 2 ++ 2 files changed, 4 insertions(+)
Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 soc platforms sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com --- Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 2ab6871e89e5..ff1a27f26bc2 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard + - qcom,qcm6490-sndcard + - qcom,qcs6490-rb3gen2-sndcard - qcom,qrb5165-rb5-sndcard - qcom,sc7180-qdsp6-sndcard - qcom,sc8280xp-sndcard
On Thu, 4 Apr 2024 at 11:48, Mohammad Rafi Shaik quic_mohs@quicinc.com wrote:
Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 soc platforms sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 2ab6871e89e5..ff1a27f26bc2 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard
- qcom,qcm6490-sndcard- qcom,qcs6490-rb3gen2-sndcard
My 2c: you are adding one soundcard for the SoC family (qcm6490) and another one for the particular board kind (qcs6490-rb3gen2). That doesn't seem logical.
- qcom,qrb5165-rb5-sndcard - qcom,sc7180-qdsp6-sndcard - qcom,sc8280xp-sndcard-- 2.25.1
On 4/4/2024 2:23 PM, Dmitry Baryshkov wrote:
On Thu, 4 Apr 2024 at 11:48, Mohammad Rafi Shaik quic_mohs@quicinc.com wrote:
Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 soc platforms sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 2ab6871e89e5..ff1a27f26bc2 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard
- qcom,qcm6490-sndcard- qcom,qcs6490-rb3gen2-sndcardMy 2c: you are adding one soundcard for the SoC family (qcm6490) and another one for the particular board kind (qcs6490-rb3gen2). That doesn't seem logical.
The qcm6490-sndcard compatible for enabling soundcard on qcm6490 IDP boards.
Will change compatible name as qcom,qcm6490-idp-sndcard.
Thanks, Rafi.
- qcom,qrb5165-rb5-sndcard - qcom,sc7180-qdsp6-sndcard - qcom,sc8280xp-sndcard-- 2.25.1
On Fri, 5 Apr 2024 at 08:56, Mohammad Rafi Shaik quic_mohs@quicinc.com wrote:
On 4/4/2024 2:23 PM, Dmitry Baryshkov wrote:
On Thu, 4 Apr 2024 at 11:48, Mohammad Rafi Shaik quic_mohs@quicinc.com wrote:
Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 soc platforms sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus keep them in existing qcom,sm8250.yaml file, even though Linux driver is separate.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml index 2ab6871e89e5..ff1a27f26bc2 100644 --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml @@ -29,6 +29,8 @@ properties: - enum: - qcom,apq8016-sbc-sndcard - qcom,msm8916-qdsp6-sndcard
- qcom,qcm6490-sndcard- qcom,qcs6490-rb3gen2-sndcardMy 2c: you are adding one soundcard for the SoC family (qcm6490) and another one for the particular board kind (qcs6490-rb3gen2). That doesn't seem logical.
The qcm6490-sndcard compatible for enabling soundcard on qcm6490 IDP boards.
Will change compatible name as qcom,qcm6490-idp-sndcard.
Any consistent way is fine with me.
Add compatibles for sound card on Qualcomm QCM6490 IDP and QCS6490 RB3Gen2 boards.
Signed-off-by: Mohammad Rafi Shaik quic_mohs@quicinc.com --- sound/soc/qcom/sc8280xp.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c index b7fd503a1666..09c949e01479 100644 --- a/sound/soc/qcom/sc8280xp.c +++ b/sound/soc/qcom/sc8280xp.c @@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev) }
static const struct of_device_id snd_sc8280xp_dt_match[] = { + {.compatible = "qcom,qcm6490-sndcard", "qcm6490"}, + {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"}, {.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"}, {.compatible = "qcom,sm8450-sndcard", "sm8450"}, {.compatible = "qcom,sm8550-sndcard", "sm8550"},
participants (2)
-
Dmitry Baryshkov -
Mohammad Rafi Shaik