[alsa-devel] [PATCH] ASoC: omap-dmic: Correct functional clock name
We should really use "fck" when asking for the functional clock and not "dmic_fck". This way we can ensure that multiple dmic modules can exist in the system.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@ti.com --- Hi Mark, Liam,
Would it be possible to send this patch for 3.7 as a fix? The DMIC driver works withoput this patch but we ask for the functional clock using the wrong name.
Thanks, Peter
sound/soc/omap/omap-dmic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/omap/omap-dmic.c b/sound/soc/omap/omap-dmic.c index 68f2cd1..5a6aeaf 100644 --- a/sound/soc/omap/omap-dmic.c +++ b/sound/soc/omap/omap-dmic.c @@ -464,9 +464,9 @@ static __devinit int asoc_dmic_probe(struct platform_device *pdev)
mutex_init(&dmic->mutex);
- dmic->fclk = clk_get(dmic->dev, "dmic_fck"); + dmic->fclk = clk_get(dmic->dev, "fck"); if (IS_ERR(dmic->fclk)) { - dev_err(dmic->dev, "cant get dmic_fck\n"); + dev_err(dmic->dev, "cant get fck\n"); return -ENODEV; }
On Fri, Oct 26, 2012 at 12:33:08PM +0200, Peter Ujfalusi wrote:
Would it be possible to send this patch for 3.7 as a fix? The DMIC driver works withoput this patch but we ask for the functional clock using the wrong name.
So, this has no practical effect but we should fix it for the next release...? I've applied it as a fix but better motivation would help for things like this.
participants (2)
-
Mark Brown
-
Peter Ujfalusi