[alsa-devel] [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication
There is some duplicate code in soc-core.c, and the kernel provides DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h.
Signed-off-by: Peng Donglin dolinux.peng@gmail.com Reviewed-by: Andy Shevchenko andy.shevchenko@gmail.com --- v3: [addressed comments from Andy] * add missing tag
v2: [addressed comments from Andy] * modify code change description * do not rename m -> s --- sound/soc/soc-core.c | 45 ++++++--------------------------------------- 1 file changed, 6 insertions(+), 39 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 96c44f6576c9..f372f34d7702 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component) "ASoC: Failed to create codec register debugfs file\n"); }
-static int codec_list_seq_show(struct seq_file *m, void *v) +static int codec_list_show(struct seq_file *m, void *v) { struct snd_soc_codec *codec;
@@ -362,20 +362,9 @@ static int codec_list_seq_show(struct seq_file *m, void *v)
return 0; } +DEFINE_SHOW_ATTRIBUTE(codec_list);
-static int codec_list_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, codec_list_seq_show, NULL); -} - -static const struct file_operations codec_list_fops = { - .open = codec_list_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; - -static int dai_list_seq_show(struct seq_file *m, void *v) +static int dai_list_show(struct seq_file *m, void *v) { struct snd_soc_component *component; struct snd_soc_dai *dai; @@ -390,20 +379,9 @@ static int dai_list_seq_show(struct seq_file *m, void *v)
return 0; } +DEFINE_SHOW_ATTRIBUTE(dai_list);
-static int dai_list_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, dai_list_seq_show, NULL); -} - -static const struct file_operations dai_list_fops = { - .open = dai_list_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; - -static int platform_list_seq_show(struct seq_file *m, void *v) +static int platform_list_show(struct seq_file *m, void *v) { struct snd_soc_platform *platform;
@@ -416,18 +394,7 @@ static int platform_list_seq_show(struct seq_file *m, void *v)
return 0; } - -static int platform_list_seq_open(struct inode *inode, struct file *file) -{ - return single_open(file, platform_list_seq_show, NULL); -} - -static const struct file_operations platform_list_fops = { - .open = platform_list_seq_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(platform_list);
static void soc_init_card_debugfs(struct snd_soc_card *card) {
On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote:
--- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component) "ASoC: Failed to create codec register debugfs file\n");
Your patch has been corrupted somewhere (probably in your mail client) - there's word wrapping here.
On Mon, Feb 12, 2018 at 3:49 AM, Mark Brown broonie@kernel.org wrote:
On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote:
--- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component) "ASoC: Failed to create codec register debugfs file\n");
Your patch has been corrupted somewhere (probably in your mail client) - there's word wrapping here.
Sorry, I will check it.
On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown broonie@kernel.org wrote:
On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote:
--- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct snd_soc_component *component) "ASoC: Failed to create codec register debugfs file\n");
Your patch has been corrupted somewhere (probably in your mail client) - there's word wrapping here.
Hi Mark, do you know the way to disable gmail word wrap in plain text mode? I find that gmail will force to wrap word at 70 characters in plain text mode.
There is a connection error when I use git send-email to send the patch because I am using VPN.
On Wed, Feb 14, 2018 at 4:39 PM, Donglin Peng dolinux.peng@gmail.com wrote:
On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown broonie@kernel.org wrote:
On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote:
Hi Mark, do you know the way to disable gmail word wrap in plain text mode? I find that gmail will force to wrap word at 70 characters in plain text mode.
There is a connection error when I use git send-email to send the patch because I am using VPN.
You may use SMTPS port (587 IIRC?) of Gmail to send a patch via git send-email.
On Wed, Feb 14, 2018 at 10:41 PM, Andy Shevchenko andy.shevchenko@gmail.com wrote:
On Wed, Feb 14, 2018 at 4:39 PM, Donglin Peng dolinux.peng@gmail.com wrote:
On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown broonie@kernel.org wrote:
On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote:
Hi Mark, do you know the way to disable gmail word wrap in plain text mode? I find that gmail will force to wrap word at 70 characters in plain text mode.
There is a connection error when I use git send-email to send the patch because I am using VPN.
You may use SMTPS port (587 IIRC?) of Gmail to send a patch via git send-email.
Thanks, I have sent it just now.
-- With Best Regards, Andy Shevchenko
participants (3)
-
Andy Shevchenko -
Donglin Peng -
Mark Brown