Re: [alsa-devel] [PATCH] ALSA: usb-audio: Fix gpf in snd_usb_pipe_sanity_check
On Tue, 30 Jul 2019 18:08:02 +0800 Takashi Iwai wrote:
You don't have to copy the whole these texts at all. In general, it'd suffice to point out the dashboard URL, and if the stack trace is mandatory, drop the useless hex numbers and just show the significant part of the stack trace.
I am used to give readers as much info as appropriate, and learning that an URL is enough in cases like this one. I will send you the pruned version next time.
It was introduced in commit 801ebf1043ae for checking pipe and endpoint types. It is fixed by adding a check of the ep pointer in question.
Reported-by: syzbot syzbot+d59c4387bfb6eced94e2@syzkaller.appspotmail.com Fixes: commit 801ebf1043ae ("ALSA: usb-audio: Sanity checks for each pipe and EP types")
Drop "commit" word.
Yes, Sir.
Cc: Andrey Konovalov andreyknvl@google.com Signed-off-by: Hillf Danton dhanton@sina.com
There is a typo, s/dhanton/hdanton/, as you pointed out in another mail.
This is to make syzbot happy for now and in long run we can make snd_usb_pipe_sanity_check() available outside sound/usb by making usb_urb_ep_type_check() a wrapper of the former. We will revisit sound/usb once when things in the usb/core get in place.
Actually I expected to apply the "long-term" fix now.
There is change in usb/core included in that fix as you see, and according to the rule, one fix a patch, it is better and simpler IMO to fix the sound part first.
The same kind of fix was already submitted from me (s5hlfwn376e.wl-tiwai@suse.de), but I didn't merge it because working on the usb core helper would be a saner solution.
Feel free to merge that, Sir.
Thanks Hillf
On Tue, 30 Jul 2019 13:28:56 +0200, Hillf Danton wrote:
On Tue, 30 Jul 2019 18:08:02 +0800 Takashi Iwai wrote:
You don't have to copy the whole these texts at all. In general, it'd suffice to point out the dashboard URL, and if the stack trace is mandatory, drop the useless hex numbers and just show the significant part of the stack trace.
I am used to give readers as much info as appropriate, and learning that an URL is enough in cases like this one. I will send you the pruned version next time.
That's fine, I already edited the commit message in my side.
It was introduced in commit 801ebf1043ae for checking pipe and endpoint types. It is fixed by adding a check of the ep pointer in question.
Reported-by: syzbot syzbot+d59c4387bfb6eced94e2@syzkaller.appspotmail.com Fixes: commit 801ebf1043ae ("ALSA: usb-audio: Sanity checks for each pipe and EP types")
Drop "commit" word.
Yes, Sir.
Cc: Andrey Konovalov andreyknvl@google.com Signed-off-by: Hillf Danton dhanton@sina.com
There is a typo, s/dhanton/hdanton/, as you pointed out in another mail.
Good, also corrected.
This is to make syzbot happy for now and in long run we can make snd_usb_pipe_sanity_check() available outside sound/usb by making usb_urb_ep_type_check() a wrapper of the former. We will revisit sound/usb once when things in the usb/core get in place.
Actually I expected to apply the "long-term" fix now.
There is change in usb/core included in that fix as you see, and according to the rule, one fix a patch, it is better and simpler IMO to fix the sound part first.
Yeah, that's a right approach, too.
What I expected was a patch series, containing two changes: one to add/modify the USB core helper and another to apply it for usb-audio. But it's fine to move that direction after addressing the usb-audio problem quickly, of course.
The same kind of fix was already submitted from me (s5hlfwn376e.wl-tiwai@suse.de), but I didn't merge it because working on the usb core helper would be a saner solution.
Feel free to merge that, Sir.
Heh, you did it right, so let's merge yours now.
Thanks!
Takashi
participants (2)
-
Hillf Danton -
Takashi Iwai