[alsa-devel] [PATCH v2 1/2] ALSA: hda - Add a new match function for only undef configurations
With the existing pintbl, we already have many entries in it. it is better to figure out a new match to reduce the size of the pintbl.
For example, there are over 10 entries in the pintbl for: 0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE
If we define a new tbl like below, and with the new adding match function, we can remove those over 10 entries: SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, {0x19, 0x40000000}, {0x1a, 0x40000000},),
Here we put 0x19 and 0x1a in the tbl just because these two pins are undefined on Dell laptops with the codec alc255, and these two pins will be overwritten by ALC255_FIXUP_DELL1_MIC_NO_PRESENCE.
In summary: the new match will check vendor id and codec id first, then check the pin_cfg defined in the tbl, only all pin_cfgs in the tbl are undef and the corresponding pin_cfgs on the laptop are undef too, this match returns true.
This new match function has lower priority than existing match functions, so the existing tbls still work as before after applying this patch.
And for the same vendor and same codec, we could define at most one undef tbl for it, for example for the Dell laptops with alc255 codec, some of them need to apply DELL1_MIC, the rest need to apply DELL2_MIC, here we could only define undef tbl for DELL1_MIC or DELL2_MIC, we could not define undef tbls for both of them.
My plan is to change the existing tbl to undef tbl for MIC_NO_PRESENCE fixups gradually.
Signed-off-by: Hui Wang hui.wang@canonical.com --- sound/pci/hda/hda_auto_parser.c | 62 ++++++++++++++++++++++++++++----- 1 file changed, 54 insertions(+), 8 deletions(-)
diff --git a/sound/pci/hda/hda_auto_parser.c b/sound/pci/hda/hda_auto_parser.c index 92390d457567..9bc2bfa0128c 100644 --- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -915,6 +915,53 @@ static bool pin_config_match(struct hda_codec *codec, return true; }
+/* Match the undef tbl with the initial verb table on the machine. + * Two nitices here: + * - define 1 undef tbl at most for the same vendor and same codec + * - the undef tbl has lower priority than normal tbls for matching + */ +static bool pin_config_match_undef(struct hda_codec *codec, + const struct hda_pintbl *pins) +{ + bool match = false; + + for (; pins->nid; pins++) { + const struct hda_pincfg *pin; + int i; + + if ((pins->val & 0xf0000000) != 0x40000000) + return false; + + match = false; + snd_array_for_each(&codec->init_pins, i, pin) { + if (pin->nid != pins->nid) + continue; + if ((pin->cfg & 0xf0000000) != 0x40000000) + return false; + match = true; + break; + } + + if (match == false) + return false; + } + + return match; +} + +static void snd_hda_set_found_fixup(struct hda_codec *codec, + const struct snd_hda_pin_quirk *pq, + const struct hda_fixup *fixlist) +{ + codec->fixup_id = pq->value; +#ifdef CONFIG_SND_DEBUG_VERBOSE + codec->fixup_name = pq->name; + codec_dbg(codec, "%s: picked fixup %s (pin match)\n", + codec->core.chip_name, codec->fixup_name); +#endif + codec->fixup_list = fixlist; +} + /** * snd_hda_pick_pin_fixup - Pick up a fixup matching with the pin quirk list * @codec: the HDA codec @@ -925,7 +972,7 @@ void snd_hda_pick_pin_fixup(struct hda_codec *codec, const struct snd_hda_pin_quirk *pin_quirk, const struct hda_fixup *fixlist) { - const struct snd_hda_pin_quirk *pq; + const struct snd_hda_pin_quirk *pq, *undef_bak_pq = NULL;
if (codec->fixup_id != HDA_FIXUP_ID_NOT_SET) return; @@ -936,16 +983,15 @@ void snd_hda_pick_pin_fixup(struct hda_codec *codec, if (codec->core.vendor_id != pq->codec) continue; if (pin_config_match(codec, pq->pins)) { - codec->fixup_id = pq->value; -#ifdef CONFIG_SND_DEBUG_VERBOSE - codec->fixup_name = pq->name; - codec_dbg(codec, "%s: picked fixup %s (pin match)\n", - codec->core.chip_name, codec->fixup_name); -#endif - codec->fixup_list = fixlist; + snd_hda_set_found_fixup(codec, pq, fixlist); return; } + if (pin_config_match_undef(codec, pq->pins)) + undef_bak_pq = pq; } + + if (undef_bak_pq != NULL) + snd_hda_set_found_fixup(codec, undef_bak_pq, fixlist); } EXPORT_SYMBOL_GPL(snd_hda_pick_pin_fixup);
We have another Dell laptop which needs the DELL4_MIC_NO_PRESENCE, and this laptop has different pincfg definitions from existing ones in the pintbl, rather adding a new entry, let us change the exiting tbl to undef tbl. It will cover all Dell laptops with alc289 codec and the pins of 0x19 and 0x1b are undef by default.
Signed-off-by: Hui Wang hui.wang@canonical.com --- sound/pci/hda/patch_realtek.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index a1439c9a635a..1c76514e32b7 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7366,6 +7366,10 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {0x12, 0x90a60130}, \ {0x21, 0x03211020}
+/* For the tbls which only contain undefined configurations like 0x40000000, + * we call them undef tbls, there is a limitation to define the undef tbl: + * - we could define at most 1 undef tbl for the same vendor and same codec + */ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { SND_HDA_PIN_QUIRK(0x10ec0221, 0x103c, "HP Workstation", ALC221_FIXUP_HP_HEADSET_MIC, {0x14, 0x01014020}, @@ -7648,9 +7652,8 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = { {0x14, 0x90170110}, {0x21, 0x0321101f}), SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE, - {0x12, 0xb7a60130}, - {0x14, 0x90170110}, - {0x21, 0x04211020}), + {0x19, 0x40000000}, + {0x1b, 0x40000000}), SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1, ALC290_STANDARD_PINS, {0x15, 0x04211040},
On Thu, 15 Aug 2019 12:14:14 +0200, Hui Wang wrote:
With the existing pintbl, we already have many entries in it. it is better to figure out a new match to reduce the size of the pintbl.
For example, there are over 10 entries in the pintbl for: 0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE
If we define a new tbl like below, and with the new adding match function, we can remove those over 10 entries: SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, {0x19, 0x40000000}, {0x1a, 0x40000000},),
Here we put 0x19 and 0x1a in the tbl just because these two pins are undefined on Dell laptops with the codec alc255, and these two pins will be overwritten by ALC255_FIXUP_DELL1_MIC_NO_PRESENCE.
In summary: the new match will check vendor id and codec id first, then check the pin_cfg defined in the tbl, only all pin_cfgs in the tbl are undef and the corresponding pin_cfgs on the laptop are undef too, this match returns true.
This new match function has lower priority than existing match functions, so the existing tbls still work as before after applying this patch.
And for the same vendor and same codec, we could define at most one undef tbl for it, for example for the Dell laptops with alc255 codec, some of them need to apply DELL1_MIC, the rest need to apply DELL2_MIC, here we could only define undef tbl for DELL1_MIC or DELL2_MIC, we could not define undef tbls for both of them.
My plan is to change the existing tbl to undef tbl for MIC_NO_PRESENCE fixups gradually.
Signed-off-by: Hui Wang hui.wang@canonical.com
The idea sounds good, but I believe it'd be less confusing if we split to two tables, one is for positive matching and another for negative matching.
And the existing fixup function can be reused for the negative matching, too, something like below.
thanks,
Takashi
--- a/sound/pci/hda/hda_auto_parser.c +++ b/sound/pci/hda/hda_auto_parser.c @@ -884,7 +884,8 @@ EXPORT_SYMBOL_GPL(snd_hda_apply_fixup); #define IGNORE_SEQ_ASSOC (~(AC_DEFCFG_SEQUENCE | AC_DEFCFG_DEF_ASSOC))
static bool pin_config_match(struct hda_codec *codec, - const struct hda_pintbl *pins) + const struct hda_pintbl *pins, + bool match_all_pins) { const struct hda_pincfg *pin; int i; @@ -908,7 +909,8 @@ static bool pin_config_match(struct hda_codec *codec, return false; } } - if (!found && (cfg & 0xf0000000) != 0x40000000) + if (match_all_pins && + !found && (cfg & 0xf0000000) != 0x40000000) return false; }
@@ -920,10 +922,12 @@ static bool pin_config_match(struct hda_codec *codec, * @codec: the HDA codec * @pin_quirk: zero-terminated pin quirk list * @fixlist: the fixup list + * @match_all_pins: all valid pins must match with the table entries */ void snd_hda_pick_pin_fixup(struct hda_codec *codec, const struct snd_hda_pin_quirk *pin_quirk, - const struct hda_fixup *fixlist) + const struct hda_fixup *fixlist, + bool match_all_pins) { const struct snd_hda_pin_quirk *pq;
@@ -935,7 +939,7 @@ void snd_hda_pick_pin_fixup(struct hda_codec *codec, continue; if (codec->core.vendor_id != pq->codec) continue; - if (pin_config_match(codec, pq->pins)) { + if (pin_config_match(codec, pq->pins, match_all_pins)) { codec->fixup_id = pq->value; #ifdef CONFIG_SND_DEBUG_VERBOSE codec->fixup_name = pq->name; --- a/sound/pci/hda/hda_local.h +++ b/sound/pci/hda/hda_local.h @@ -361,7 +361,8 @@ void snd_hda_pick_fixup(struct hda_codec *codec, const struct hda_fixup *fixlist); void snd_hda_pick_pin_fixup(struct hda_codec *codec, const struct snd_hda_pin_quirk *pin_quirk, - const struct hda_fixup *fixlist); + const struct hda_fixup *fixlist, + bool match_all_pins);
/* helper macros to retrieve pin default-config values */ #define get_defcfg_connect(cfg) \ --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -7950,7 +7950,7 @@ static int patch_alc269(struct hda_codec *codec)
snd_hda_pick_fixup(codec, alc269_fixup_models, alc269_fixup_tbl, alc269_fixups); - snd_hda_pick_pin_fixup(codec, alc269_pin_fixup_tbl, alc269_fixups); + snd_hda_pick_pin_fixup(codec, alc269_pin_fixup_tbl, alc269_fixups, true); snd_hda_pick_fixup(codec, NULL, alc269_fixup_vendor_tbl, alc269_fixups); snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_PRE_PROBE); @@ -8935,7 +8935,7 @@ static int patch_alc662(struct hda_codec *codec)
snd_hda_pick_fixup(codec, alc662_fixup_models, alc662_fixup_tbl, alc662_fixups); - snd_hda_pick_pin_fixup(codec, alc662_pin_fixup_tbl, alc662_fixups); + snd_hda_pick_pin_fixup(codec, alc662_pin_fixup_tbl, alc662_fixups, true); snd_hda_apply_fixup(codec, HDA_FIXUP_ACT_PRE_PROBE);
alc_auto_parse_customize_define(codec);
participants (2)
-
Hui Wang -
Takashi Iwai