[alsa-devel] [PATCH] Allow more routing features for tlv320aic3x
Hi,
this patch adds more routing possibilities to the tlv320aic3x code driver. Stereo mixers are, as dicussed earlier, not appropriate due to the versatile channel functions of this rather complex chip.
Best regards, Daniel
On Wed, Nov 26, 2008 at 03:48:54PM +0100, Daniel Mack wrote:
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
- SOC_DOUBLE_R("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
PGAR_2_HPLOUT_VOL, 0, 0x7f, 1),- SOC_DOUBLE_R("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL, PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
This should be two SOC_DOUBLEs (the end result is the same but that's due to the implementation rather than anything else). Other than that the patch looks fine, though a more verbose patch description describing briefly the routes that are being added (looks like mostly left<->right cross connects?) would be nice.
On Wed, Nov 26, 2008 at 03:04:05PM +0000, Mark Brown wrote:
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
- SOC_DOUBLE_R("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
PGAR_2_HPLOUT_VOL, 0, 0x7f, 1),- SOC_DOUBLE_R("HPR PGA Bypass Playback Volume", PGAL_2_HPROUT_VOL, PGAR_2_HPROUT_VOL, 0, 0x7f, 1),
This should be two SOC_DOUBLEs (the end result is the same but that's due to the implementation rather than anything else). Other than that the patch looks fine, though a more verbose patch description describing briefly the routes that are being added (looks like mostly left<->right cross connects?) would be nice.
Thanks for your comments, new version attached.
Best regards, Daniel
On Wed, Nov 26, 2008 at 04:28:11PM +0000, Mark Brown wrote:
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
- SOC_DOUBLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
PGAR_2_HPLOUT_VOL, 0, 0x7f, 1),Meh, sorry - I meant SOC_SINGLE here. My mistake.
Ok, here we go :)
On Wed, Nov 26, 2008 at 04:28:11PM +0000, Mark Brown wrote:
- SOC_DOUBLE_R("HP PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
- SOC_DOUBLE("HPL PGA Bypass Playback Volume", PGAL_2_HPLOUT_VOL,
PGAR_2_HPLOUT_VOL, 0, 0x7f, 1),Meh, sorry - I meant SOC_SINGLE here. My mistake.
Sorry, once more. I was a little too quick with my last submission.
Best regards, Daniel
On Wed, Nov 26, 2008 at 05:47:36PM +0100, Daniel Mack wrote:
Sorry, once more. I was a little too quick with my last submission.
Applied, thanks. BTW...
- control the volume of the PGA bypass path for the HPL, HPR, HPLCOM and HPRCOM outputs individually
...that's not quite true; ALSA does allow left and right channels to be controlled independently for stereo controls, it's just not the default thing in UIs (and not always idiomatic when the left and right paths are sufficiently independent so the change is OK).
participants (2)
-
Daniel Mack -
Mark Brown