[alsa-devel] [PATCH] ASoC: wm8731: init mutex in i2c init path
The I2C init path forgot to init the mutex, leading to an oops when controls are accessed.
Signed-off-by: Manuel Lauss manuel.lauss@gmail.com --- Fixes an oops on bootup when alsactl tries to restore codec parameters on my MIPS DB1300 board.
sound/soc/codecs/wm8731.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index b9211b4..b115ed8 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c @@ -717,6 +717,8 @@ static int wm8731_i2c_probe(struct i2c_client *i2c, if (wm8731 == NULL) return -ENOMEM;
+ mutex_init(&wm8731->lock); + wm8731->regmap = devm_regmap_init_i2c(i2c, &wm8731_regmap); if (IS_ERR(wm8731->regmap)) { ret = PTR_ERR(wm8731->regmap);
On Mon, Jan 19, 2015 at 08:23:43AM +0100, Manuel Lauss wrote:
The I2C init path forgot to init the mutex, leading to an oops when controls are accessed.
Applied, thanks. Please remember to CC maintainers on patches, including driver maintainers as well as subsystem maintainers.
participants (2)
-
Manuel Lauss
-
Mark Brown