From: Colin Ian King colin.king@canonical.com

Currently the check for too many retries fails because retries is actually -1 when the retry loop terminates if no pbuf can be allocated because of the post decrement on retries. Fix this by not comparing retries with zero but instead check if it is negative.

Detected by CoverityScan, CID#1463143 ("Logically dead code") and CID#1463144 ("Dereference after null check")

Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver") Signed-off-by: Colin Ian King colin.king@canonical.com --- drivers/slimbus/qcom-ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index 35ad70dbfe3a..9b7846f1f8c3 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -347,7 +347,7 @@ static int qcom_xfer_msg(struct slim_controller *sctrl, } }

- if (!retries && !pbuf) + if (retries < 0 && !pbuf) return -ENOMEM;

puc = (u8 *)pbuf;