[alsa-devel] [asoc:for-3.7 95/95] sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
[add more CC on request of Dimitris]
Hi Dimitris, Mark,
FYI, there are new coccinelle warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7 head: e3523e01869da20fdd12ffd19ae1df7bf492650e commit: e3523e01869da20fdd12ffd19ae1df7bf492650e [95/95] ASoC: wm0010: Add initial wm0010 DSP driver
All coccinelle warnings:
+ sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT -- + sound/soc/codecs/wm0010.c:660:1-7: preceding lock on line 359
vim +850 sound/soc/codecs/wm0010.c 847 trigger = IRQF_TRIGGER_FALLING; 848 trigger |= IRQF_ONESHOT; 849
850 ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
851 "wm0010", wm0010); 852 if (ret) 853 dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",
Please consider folding the attached diff :-)
--- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu wfg@linux.intel.com Intel Corporation
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
[PATCH] wm0010: fix coccinelle warnings
/c/kernel-tests/src/linux/sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Gah, just noticed the patch buried in here. If you're generating stuff like this I'd suggest restructuring the submission so it comes out as an normal patch, it's not at all obvious that there's a patch in the mail and even if one notices. In this case I'd mostly ignored your mail as I expected Dimitris to fix it, will apply now.
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
[PATCH] wm0010: fix coccinelle warnings
/c/kernel-tests/src/linux/sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Gah, just noticed the patch buried in here. If you're generating stuff like this I'd suggest restructuring the submission so it comes out as an normal patch, it's not at all obvious that there's a patch in the mail and even if one notices. In this case I'd mostly ignored your mail as I expected Dimitris to fix it, will apply now.
Oh I forgot it, too. Sorry! It does look better be submitted as a patch rather than a coccinelle warning.
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Thanks, Fengguang
On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Yes.
On Wed, 5 Sep 2012, Mark Brown wrote:
On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Yes.
I'm missing some context...
julia
On Wed, Sep 05, 2012 at 03:33:26PM +0200, Julia Lawall wrote:
On Wed, 5 Sep 2012, Mark Brown wrote:
On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Yes.
I'm missing some context...
Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?
Thanks, Fengguang
On Wed, 5 Sep 2012, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 03:33:26PM +0200, Julia Lawall wrote:
On Wed, 5 Sep 2012, Mark Brown wrote:
On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Yes.
I'm missing some context...
Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?
I do have a tool, but it doesn't exactly take the output produced by coccicheck. I can look into how this could be done.
The input desired would be the text printed by Coccinelle and a patch generated by git?
julia
On Wed, Sep 05, 2012 at 03:55:13PM +0200, Julia Lawall wrote:
On Wed, 5 Sep 2012, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 03:33:26PM +0200, Julia Lawall wrote:
On Wed, 5 Sep 2012, Mark Brown wrote:
On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote:
On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Yes.
I'm missing some context...
Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?
I do have a tool, but it doesn't exactly take the output produced by coccicheck. I can look into how this could be done.
The input desired would be the text printed by Coccinelle and a patch generated by git?
I'm just adapting the coccinelle generated diff into a mechanically formated patch.
Here is the discussed patch, generated by a simple script. It mainly serves as a good start point for patch submission.
: [PATCH] wm0010: fix coccinelle warnings : : sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT : : Make sure threaded IRQs without a primary handler are always request with : IRQF_ONESHOT : : Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci : : Signed-off-by: Fengguang Wu fengguang.wu@intel.com : --- : : Please take the patch only if it's a positive warning. Thanks! : : cocci-output-17570-fcfaec-wm0010.c | 2 +- : 1 file changed, 1 insertion(+), 1 deletion(-) : : --- a/sound/soc/codecs/wm0010.c : +++ b/sound/soc/codecs/wm0010.c : @@ -847,7 +847,7 @@ static int wm0010_probe(struct snd_soc_c : trigger = IRQF_TRIGGER_FALLING; : trigger |= IRQF_ONESHOT; : : - ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger, : + ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT, : "wm0010", wm0010); : if (ret) : dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n", :
Thanks, Fengguang
On Wed, 5 Sep 2012, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 03:55:13PM +0200, Julia Lawall wrote:
On Wed, 5 Sep 2012, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 03:33:26PM +0200, Julia Lawall wrote:
On Wed, 5 Sep 2012, Mark Brown wrote:
On Wed, Sep 05, 2012 at 01:56:09PM +0800, Fengguang Wu wrote:
On Wed, Sep 05, 2012 at 06:40:25AM +0100, Mark Brown wrote: > On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:
> Julia generally does a pretty good job of formatting her mails, perhaps > there's some scripts she uses whcih would help?
Julia Lawall? Added CC to her.
Yes.
I'm missing some context...
Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?
I do have a tool, but it doesn't exactly take the output produced by coccicheck. I can look into how this could be done.
The input desired would be the text printed by Coccinelle and a patch generated by git?
I'm just adapting the coccinelle generated diff into a mechanically formated patch.
Here is the discussed patch, generated by a simple script. It mainly serves as a good start point for patch submission.
: [PATCH] wm0010: fix coccinelle warnings : : sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT : : Make sure threaded IRQs without a primary handler are always request with : IRQF_ONESHOT : : Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci : : Signed-off-by: Fengguang Wu fengguang.wu@intel.com : --- : : Please take the patch only if it's a positive warning. Thanks! : : cocci-output-17570-fcfaec-wm0010.c | 2 +- : 1 file changed, 1 insertion(+), 1 deletion(-) : : --- a/sound/soc/codecs/wm0010.c : +++ b/sound/soc/codecs/wm0010.c : @@ -847,7 +847,7 @@ static int wm0010_probe(struct snd_soc_c : trigger = IRQF_TRIGGER_FALLING; : trigger |= IRQF_ONESHOT; : : - ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger, : + ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT, : "wm0010", wm0010); : if (ret) : dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n", :
I'm not sure what could be done better...
julia
On Wed, Sep 05, 2012 at 10:01:12PM +0200, Julia Lawall wrote:
I'm not sure what could be done better...
The patch itself was fine but it was buried as an attachment to a mail that didn't have anything like a [PATCH] tag or anything so it was very hidden when it turned up in e-mail.
On Thu, Sep 06, 2012 at 06:20:50AM +0800, Mark Brown wrote:
On Wed, Sep 05, 2012 at 10:01:12PM +0200, Julia Lawall wrote:
I'm not sure what could be done better...
The patch itself was fine but it was buried as an attachment to a mail that didn't have anything like a [PATCH] tag or anything so it was very hidden when it turned up in e-mail.
Yes, this is a problem. I'll avoid such hidden coccinelle patches in future.
Thanks for the reminding!
Fengguang
participants (3)
-
Fengguang Wu -
Julia Lawall -
Mark Brown