[alsa-devel] [PATCH v2] ASoC: ssm2518: Add explicit device tree support
Add OF match table to SSM2518 to allow direct matching without going through I2C subsystem.
Signed-off-by: Ricard Wanderlof ricardw@axis.com
--- sound/soc/codecs/ssm2518.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c index 67ea55a..2d199b1 100644 --- a/sound/soc/codecs/ssm2518.c +++ b/sound/soc/codecs/ssm2518.c @@ -811,6 +811,14 @@ static int ssm2518_i2c_remove(struct i2c_client *client) return 0; }
+#ifdef CONFIG_OF +static const struct of_device_id ssm2518_dt_ids[] = { + { .compatible = "adi,ssm2518", }, + { } +}; +MODULE_DEVICE_TABLE(of, ssm2518_dt_ids); +#endif + static const struct i2c_device_id ssm2518_i2c_ids[] = { { "ssm2518", 0 }, { } @@ -821,6 +829,7 @@ static struct i2c_driver ssm2518_driver = { .driver = { .name = "ssm2518", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(ssm2518_dt_ids), }, .probe = ssm2518_i2c_probe, .remove = ssm2518_i2c_remove,
On 08/13/2015 03:10 PM, Ricard Wanderlof wrote:
Add OF match table to SSM2518 to allow direct matching without going through I2C subsystem.
Signed-off-by: Ricard Wanderlof ricardw@axis.com
Acked-by: Lars-Peter Clausen lars@metafoo.de
Thanks.
On Thu, Aug 13, 2015 at 03:10:19PM +0200, Ricard Wanderlof wrote:
Add OF match table to SSM2518 to allow direct matching without going through I2C subsystem.
Signed-off-by: Ricard Wanderlof ricardw@axis.com
sound/soc/codecs/ssm2518.c | 9 +++++++++ 1 file changed, 9 insertions(+)
You should document all new DT bindings (even if they did implicitly happen to work before).
On Fri, 14 Aug 2015, Mark Brown wrote:
On Thu, Aug 13, 2015 at 03:10:19PM +0200, Ricard Wanderlof wrote:
Add OF match table to SSM2518 to allow direct matching without going through I2C subsystem.
Signed-off-by: Ricard Wanderlof ricardw@axis.com
sound/soc/codecs/ssm2518.c | 9 +++++++++ 1 file changed, 9 insertions(+)
You should document all new DT bindings (even if they did implicitly happen to work before).
Do you mean in the commit message then? (The patch doesn't implement any bindings not already described in Documentation/devicetree/bindings/sound/ssm2518.txt).
/Ricard
On Mon, Aug 17, 2015 at 08:43:23AM +0200, Ricard Wanderlof wrote:
On Fri, 14 Aug 2015, Mark Brown wrote:
Add OF match table to SSM2518 to allow direct matching without going through I2C subsystem.
Signed-off-by: Ricard Wanderlof ricardw@axis.com
sound/soc/codecs/ssm2518.c | 9 +++++++++ 1 file changed, 9 insertions(+)
You should document all new DT bindings (even if they did implicitly happen to work before).
Do you mean in the commit message then? (The patch doesn't implement any bindings not already described in Documentation/devicetree/bindings/sound/ssm2518.txt).
No, I mean the binding file. In the unusual case that there's one already that's not had the driver side changes made then you should mention that it exists in the changelog.
The patch
ASoC: ssm2518: Add explicit device tree support
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 4b8be271e94c872ae6e1ed2c05845002de89f71c Mon Sep 17 00:00:00 2001
From: Ricard Wanderlof ricard.wanderlof@axis.com Date: Thu, 13 Aug 2015 15:10:19 +0200 Subject: [PATCH] ASoC: ssm2518: Add explicit device tree support
Add OF match table to SSM2518 to allow direct matching without going through I2C subsystem.
Signed-off-by: Ricard Wanderlof ricardw@axis.com Acked-by: Lars-Peter Clausen lars@metafoo.de Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/codecs/ssm2518.c | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c index f30de76..b49f216 100644 --- a/sound/soc/codecs/ssm2518.c +++ b/sound/soc/codecs/ssm2518.c @@ -806,6 +806,14 @@ static int ssm2518_i2c_remove(struct i2c_client *client) return 0; }
+#ifdef CONFIG_OF +static const struct of_device_id ssm2518_dt_ids[] = { + { .compatible = "adi,ssm2518", }, + { } +}; +MODULE_DEVICE_TABLE(of, ssm2518_dt_ids); +#endif + static const struct i2c_device_id ssm2518_i2c_ids[] = { { "ssm2518", 0 }, { } @@ -816,6 +824,7 @@ static struct i2c_driver ssm2518_driver = { .driver = { .name = "ssm2518", .owner = THIS_MODULE, + .of_match_table = of_match_ptr(ssm2518_dt_ids), }, .probe = ssm2518_i2c_probe, .remove = ssm2518_i2c_remove,
participants (3)
-
Lars-Peter Clausen -
Mark Brown -
Ricard Wanderlof