Re: [PATCH] ASoC: rt1316: Add RT1316 SDCA vendor-specific driver
On Tue, Feb 09, 2021 at 01:34:24AM +0000, Shuming [范書銘] wrote:
Right, this was my expectation for how this would work - dynamic control at runtime so you can do stuff like that rather than a more static setup like slot assignment is normally..
Actually, the "RX Channel Select" control could select the channel. This control could select the different channels to output dynamically. However, could I keep the rt1316_sdw_set_tdm_slot() here? There will be more options to set this configuration.
If there's a control to override it at runtime then duplicating that with set_tdm_slot() seems like it's going to be a route to confusion if people change it?
Right, this was my expectation for how this would work - dynamic control at runtime so you can do stuff like that rather than a more static setup like slot assignment is normally..
Actually, the "RX Channel Select" control could select the channel. This control could select the different channels to output dynamically. However, could I keep the rt1316_sdw_set_tdm_slot() here? There will be more options to set this configuration.
If there's a control to override it at runtime then duplicating that with set_tdm_slot() seems like it's going to be a route to confusion if people change it?
Sorry for the late reply. Ok, I will remove the set_tdm_slot() and send v2 patch.
participants (2)
-
Mark Brown -
Shuming [范書銘]