[alsa-devel] [PATCH] ASoC: ak4535: Set codec->hw_write to i2c_master_send

It was removed in commit f0fba2ad "ASoC: multi-component - ASoC Multi-Component Support".
Add it back, otherwise codec->hw_write points to NULL.
Signed-off-by: Axel Lin axel.lin@gmail.com --- sound/soc/codecs/ak4535.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/ak4535.c b/sound/soc/codecs/ak4535.c index e1a214e..00cc92c 100644 --- a/sound/soc/codecs/ak4535.c +++ b/sound/soc/codecs/ak4535.c @@ -439,6 +439,7 @@ static int ak4535_probe(struct snd_soc_codec *codec)
printk(KERN_INFO "AK4535 Audio Codec %s", AK4535_VERSION);
+ codec->hw_write = (hw_write_t)i2c_master_send; codec->control_data = ak4535->control_data;
/* power on device */

On Wed, Oct 05, 2011 at 03:27:56PM +0800, Axel Lin wrote:
It was removed in commit f0fba2ad "ASoC: multi-component - ASoC Multi-Component Support".
Add it back, otherwise codec->hw_write points to NULL.
It's better to fix the driver not to use hw_write any more, it's broken without anyway.

2011/10/6 Mark Brown broonie@opensource.wolfsonmicro.com:
On Wed, Oct 05, 2011 at 03:27:56PM +0800, Axel Lin wrote:
It was removed in commit f0fba2ad "ASoC: multi-component - ASoC Multi-Component Support".
Add it back, otherwise codec->hw_write points to NULL.
It's better to fix the driver not to use hw_write any more, it's broken without anyway.
It's better convert to soc-cache. But this one-line-fix may be ok for 3.1.
participants (2)
-
Axel Lin
-
Mark Brown