[tiwai-sound:test/snd_ctl_remove-lock-fix 31/38] sound/soc/mediatek/mt8188/mt8188-mt6359.c:1000:25: error: implicit declaration of function 'snd_ctl_remove'; did you mean 'snd_ctl_rename'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git test/snd_ctl_remove-lock-fix head: 1daeb793bc0d3c3ad9a66718852a4be0584b700c commit: 664c9b8fd2f9e61cbe85d8015fc1962ed10d8a2a [31/38] ALSA: control: Drop snd_ctl_remove() config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20230705/202307051751.ewoQ5wky-lkp@i...) compiler: arm-linux-gnueabi-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230705/202307051751.ewoQ5wky-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202307051751.ewoQ5wky-lkp@intel.com/
All errors (new ones prefixed by >>):
sound/soc/mediatek/mt8188/mt8188-mt6359.c: In function 'mt8188_fixup_controls':
sound/soc/mediatek/mt8188/mt8188-mt6359.c:1000:25: error: implicit declaration of function 'snd_ctl_remove'; did you mean 'snd_ctl_rename'? [-Werror=implicit-function-declaration]
1000 | snd_ctl_remove(card->snd_card, kctl); | ^~~~~~~~~~~~~~ | snd_ctl_rename cc1: some warnings being treated as errors
vim +1000 sound/soc/mediatek/mt8188/mt8188-mt6359.c
9f08dcbddeb307 Trevor Wu 2023-05-26 981 9f08dcbddeb307 Trevor Wu 2023-05-26 982 static void mt8188_fixup_controls(struct snd_soc_card *card) 9f08dcbddeb307 Trevor Wu 2023-05-26 983 { 9f08dcbddeb307 Trevor Wu 2023-05-26 984 struct mt8188_mt6359_priv *priv = snd_soc_card_get_drvdata(card); 9f08dcbddeb307 Trevor Wu 2023-05-26 985 struct mt8188_card_data *card_data = (struct mt8188_card_data *)priv->private_data; 9f08dcbddeb307 Trevor Wu 2023-05-26 986 struct snd_kcontrol *kctl; 9f08dcbddeb307 Trevor Wu 2023-05-26 987 9f08dcbddeb307 Trevor Wu 2023-05-26 988 if (card_data->quirk & NAU8825_HS_PRESENT) { 9f08dcbddeb307 Trevor Wu 2023-05-26 989 struct snd_soc_dapm_widget *w, *next_w; 9f08dcbddeb307 Trevor Wu 2023-05-26 990 9f08dcbddeb307 Trevor Wu 2023-05-26 991 for_each_card_widgets_safe(card, w, next_w) { 9f08dcbddeb307 Trevor Wu 2023-05-26 992 if (strcmp(w->name, "Headphone")) 9f08dcbddeb307 Trevor Wu 2023-05-26 993 continue; 9f08dcbddeb307 Trevor Wu 2023-05-26 994 9f08dcbddeb307 Trevor Wu 2023-05-26 995 snd_soc_dapm_free_widget(w); 9f08dcbddeb307 Trevor Wu 2023-05-26 996 } 9f08dcbddeb307 Trevor Wu 2023-05-26 997 9f08dcbddeb307 Trevor Wu 2023-05-26 998 kctl = ctl_find(card->snd_card, "Headphone Switch"); 9f08dcbddeb307 Trevor Wu 2023-05-26 999 if (kctl) 9f08dcbddeb307 Trevor Wu 2023-05-26 @1000 snd_ctl_remove(card->snd_card, kctl); 9f08dcbddeb307 Trevor Wu 2023-05-26 1001 else 9f08dcbddeb307 Trevor Wu 2023-05-26 1002 dev_warn(card->dev, "Cannot find ctl : Headphone Switch\n"); 9f08dcbddeb307 Trevor Wu 2023-05-26 1003 } 9f08dcbddeb307 Trevor Wu 2023-05-26 1004 } 9f08dcbddeb307 Trevor Wu 2023-05-26 1005
:::::: The code at line 1000 was first introduced by commit :::::: 9f08dcbddeb307793bbfff036db213d2cdf03a50 ASoC: mediatek: mt8188-mt6359: support new board with nau88255
:::::: TO: Trevor Wu trevor.wu@mediatek.com :::::: CC: Mark Brown broonie@kernel.org
participants (1)
-
kernel test robot