[PATCH -next v2] ALSA: Make SND_PCMTEST depend on DEBUG_FS
Since pcmtest is a test module that manipulates or gets notification via debugfs, without DEBUG_FS it can not work fine. So make SND_PCMTEST depend on DEBUG_FS.
Signed-off-by: Ruan Jinjie ruanjinjie@huawei.com --- v2: - make it depend on DEBUG_FS instead of dropping error check. --- sound/drivers/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig index 41c171468c1e..6debd8e95cb7 100644 --- a/sound/drivers/Kconfig +++ b/sound/drivers/Kconfig @@ -111,6 +111,7 @@ config SND_ALOOP
config SND_PCMTEST tristate "Virtual PCM test driver" + depends on DEBUG_FS select SND_PCM help Say 'Y' or 'M' to include support for the Virtual PCM test driver.
On 8/17/23 13:37, Ruan Jinjie wrote:
Since pcmtest is a test module that manipulates or gets notification via debugfs, without DEBUG_FS it can not work fine. So make SND_PCMTEST depend on DEBUG_FS.
Signed-off-by: Ruan Jinjie ruanjinjie@huawei.com
v2:
- make it depend on DEBUG_FS instead of dropping error check.
sound/drivers/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/drivers/Kconfig b/sound/drivers/Kconfig index 41c171468c1e..6debd8e95cb7 100644 --- a/sound/drivers/Kconfig +++ b/sound/drivers/Kconfig @@ -111,6 +111,7 @@ config SND_ALOOP
config SND_PCMTEST tristate "Virtual PCM test driver"
- depends on DEBUG_FS select SND_PCM help Say 'Y' or 'M' to include support for the Virtual PCM test driver.
Looks good to me, thanks!
Acked-by: Ivan Orlov ivan.orlov0322@gmail.com
On Thu, 17 Aug 2023 11:37:39 +0200, Ruan Jinjie wrote:
Since pcmtest is a test module that manipulates or gets notification via debugfs, without DEBUG_FS it can not work fine. So make SND_PCMTEST depend on DEBUG_FS.
Signed-off-by: Ruan Jinjie ruanjinjie@huawei.com
v2:
- make it depend on DEBUG_FS instead of dropping error check.
Applied now. Thanks.
Takashi
participants (3)
-
Ivan Orlov -
Ruan Jinjie -
Takashi Iwai