[alsa-devel] [topic/asoc][PATCH] ASoC: Fix DSP formats in SSM2602 audio codec
Thanks to Troy Kisky troy.kisky@boundarydevices.com for noticing.
- DSP_A format has 1-bit data delay which corresponds to SSM6202 submode 2 - DSP_B has 0-bit data delay which corresponds to submode 1 - Currently driver sets them opposite so swap the submode setting
Signed-off-by: Jarkko Nikula jarkko.nikula@nokia.com Cc: Cliff Cai cliff.cai@analog.com --- sound/soc/codecs/ssm2602.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c index 2325aef..cac3736 100644 --- a/sound/soc/codecs/ssm2602.c +++ b/sound/soc/codecs/ssm2602.c @@ -454,10 +454,10 @@ static int ssm2602_set_dai_fmt(struct snd_soc_dai *codec_dai, iface |= 0x0001; break; case SND_SOC_DAIFMT_DSP_A: - iface |= 0x0003; + iface |= 0x0013; break; case SND_SOC_DAIFMT_DSP_B: - iface |= 0x0013; + iface |= 0x0003; break; default: return -EINVAL;
On Mon, Dec 22, 2008 at 10:57:33AM +0200, Jarkko Nikula wrote:
Thanks to Troy Kisky troy.kisky@boundarydevices.com for noticing.
- DSP_A format has 1-bit data delay which corresponds to SSM6202 submode 2
- DSP_B has 0-bit data delay which corresponds to submode 1
- Currently driver sets them opposite so swap the submode setting
Signed-off-by: Jarkko Nikula jarkko.nikula@nokia.com Cc: Cliff Cai cliff.cai@analog.com
Presumably this means that the Blackfin I2S driver also needs to be updated (probably just replacing DSP_A with DSP_B by the looks of it)? Though since the SSM6206 machine driver uses I2S it shouldn't matter too much if they're out of sync temporarily.
On Mon, Dec 22, 2008 at 4:45 PM, Mark Brown < broonie@opensource.wolfsonmicro.com> wrote:
On Mon, Dec 22, 2008 at 10:57:33AM +0200, Jarkko Nikula wrote:
Thanks to Troy Kisky troy.kisky@boundarydevices.com for noticing.
- DSP_A format has 1-bit data delay which corresponds to SSM6202 submode
2
- DSP_B has 0-bit data delay which corresponds to submode 1
- Currently driver sets them opposite so swap the submode setting
Signed-off-by: Jarkko Nikula jarkko.nikula@nokia.com Cc: Cliff Cai cliff.cai@analog.com
Presumably this means that the Blackfin I2S driver also needs to be updated (probably just replacing DSP_A with DSP_B by the looks of it)? Though since the SSM6206 machine driver uses I2S it shouldn't matter too much if they're out of sync temporarily.
That was my first impression as well, but then I noticed that bf5xx-ad73311.c machine driver is using DSP_A and AD73311 looks like it's hard coded for DSP_A. Hopefully bf5xx-i2s and ssm2602 are still compatible with each other if using DSP_A :-)
Jarkko
participants (3)
-
Jarkko Nikula -
Jarkko Nikula -
Mark Brown