[alsa-devel] [PATCH] ASoC: Intel: Atom: fix regression on compress DAI
Commit a1068045883ed4a18363a4ebad0c3d55e473b716 added a dependency on the compress-cpu-dai channel_min field which was removed earlier by commit 77095796ae9cbaf315f80611edb5aa569796e339 as part of the baytrail cleanups.
The net result was a regression at probe on all Atom platforms with no sound card created.
Fix by adding explicit initialization for channel_min to 1 for the compress-cpu-dai.
Reported-by: Tobias Mädel alsa-devel@tbspace.de Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c index 55c33dc..52ed434 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -528,6 +528,7 @@ static struct snd_soc_dai_driver sst_platform_dai[] = { .ops = &sst_compr_dai_ops, .playback = { .stream_name = "Compress Playback", + .channels_min = 1, }, }, /* BE CPU Dais */
On Mon, Feb 01, 2016 at 01:25:16PM -0600, Pierre-Louis Bossart wrote:
Commit a1068045883ed4a18363a4ebad0c3d55e473b716 added a dependency on the compress-cpu-dai channel_min field which was removed earlier by commit 77095796ae9cbaf315f80611edb5aa569796e339 as part of the baytrail cleanups.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access or slow internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
Please also use abbreviated commit IDs, the entire SHA1 is a bit long and does nothing for legibility.
The patch
ASoC: Intel: Atom: fix regression on compress DAI
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark
From 292d4200a90715ac29f3763df27adb38a243868c Mon Sep 17 00:00:00 2001
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Date: Tue, 2 Feb 2016 12:49:49 -0600 Subject: [PATCH] ASoC: Intel: Atom: fix regression on compress DAI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Commit a106804 ("ASoC: compress: Fix compress device direction check") added a dependency on the compress-cpu-dai channel_min field which was removed earlier by commit 77095796 ("ASoC: Intel: Atom: clean-up compressed DAI definition") as part of the baytrail cleanups.
The net result was a regression at probe on all Atom platforms with no sound card created.
Fix by adding explicit initialization for channel_min to 1 for the compress-cpu-dai.
Reported-by: Tobias Mädel alsa-devel@tbspace.de Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown broonie@kernel.org --- sound/soc/intel/atom/sst-mfld-platform-pcm.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c index 55c33dc76ce4..52ed434cbca6 100644 --- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c +++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c @@ -528,6 +528,7 @@ static struct snd_soc_dai_driver sst_platform_dai[] = { .ops = &sst_compr_dai_ops, .playback = { .stream_name = "Compress Playback", + .channels_min = 1, }, }, /* BE CPU Dais */
participants (2)
-
Mark Brown -
Pierre-Louis Bossart