[alsa-devel] [PATCH] ASoC: Allow use sleeping gpio in soc-jack
It is safe to use sleeping gpio in snd_soc_jack_gpio_detect as it is not called from interrupt context. This avoids WARN_ON from __gpio_get_value if sleeping gpio is registered for jack.
Signed-off-by: Jarkko Nikula jhnikula@gmail.com --- Only compile tested. --- sound/soc/soc-jack.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c index 99dbaf7..4579ee0 100644 --- a/sound/soc/soc-jack.c +++ b/sound/soc/soc-jack.c @@ -240,7 +240,7 @@ static void snd_soc_jack_gpio_detect(struct snd_soc_jack_gpio *gpio) int enable; int report;
- enable = gpio_get_value(gpio->gpio); + enable = gpio_get_value_cansleep(gpio->gpio); if (gpio->invert) enable = !enable;
On Thu, 2011-02-10 at 17:22 +0200, Jarkko Nikula wrote:
It is safe to use sleeping gpio in snd_soc_jack_gpio_detect as it is not called from interrupt context. This avoids WARN_ON from __gpio_get_value if sleeping gpio is registered for jack.
Signed-off-by: Jarkko Nikula jhnikula@gmail.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
participants (3)
-
Jarkko Nikula
-
Liam Girdwood
-
Mark Brown