Hello Vinod Koul,

The patch 24c8d14192cc: "ASoC: Intel: mrfld: add DSP core controls" from Oct 15, 2014, leads to the following static checker warning:

sound/soc/intel/sst-atom-controls.c:1354 sst_map_modules_to_pipe() warn: variable dereferenced before check 'platform' (see line 1353)

sound/soc/intel/sst-atom-controls.c 1348 static int sst_map_modules_to_pipe(struct snd_soc_platform *platform) 1349 { 1350 struct snd_soc_dapm_widget *w; 1351 int ret = 0; 1352 1353 list_for_each_entry(w, &platform->component.card->widgets, list) { ^^^^^^^^ New dereference.

1354 if (platform && is_sst_dapm_widget(w) && (w->priv)) { ^^^^^^^^ New check.

1355 struct sst_ids *ids = w->priv; 1356 1357 dev_dbg(platform->dev, "widget type=%d name=%s\n", 1358 w->id, w->name); 1359 INIT_LIST_HEAD(&ids->algo_list); 1360 INIT_LIST_HEAD(&ids->gain_list); 1361 ret = sst_fill_widget_module_info(w, platform); 1362 1363 if (ret < 0) 1364 return ret; 1365 1366 /* fill linked widgets */ 1367 if (ids->parent_wname != NULL) 1368 sst_fill_linked_widgets(platform, ids); 1369 } 1370 } 1371 return 0; 1372 }

regards, dan carpenter