On Fri, Feb 28, 2020 at 2:41 AM Nicolin Chen nicoleotsuka@gmail.com wrote:
On Thu, Feb 27, 2020 at 10:41:56AM +0800, Shengjiu Wang wrote:
There is a new ASRC included in i.MX serial platform, there are some common definition can be shared with each other. So move the common definition to a separate header file.
And add fsl_asrc_pair_internal and fsl_asrc_internal for the variable specific for the module, which can be used internally.
I think we can just call it "priv", instead of "internal", since it's passed by the "void *private" pointer.
And it'd be nicer to have an extra preparational patch to rename existing "struct fsl_asrc *asrc_priv" to "struct fsl_asrc *asrc".
Something like: struct fsl_asrc *asrc = yyyy; struct fsl_asrc_pair *pair = xxxx; struct fsl_asrc_priv *asrc_priv = asrc->private; struct fsl_asrc_pair_priv *pair_priv = pair->private;
Thanks
ok, will change it.
best regards wang shengjiu