On 26/06/14 22:20, Jyri Sarha wrote:
Integrate ASoC DAI component driver in to the OMAP hdmi driver. The patch also updates the relevant entry in ti,omap5-dss DT binding document. The driver registers a dummy hdmi codec driver and a simple-card driver to produce a fully functional ALSA device. The DAI driver is implemented in hdmi_audio.c, but it still needs to be registered from hdmi4.c or hdmi5.c.
Signed-off-by: Jyri Sarha jsarha@ti.com
<snip>
+static const struct snd_soc_dai_ops hdmi_dai_ops = {
- .startup = hdmi_dai_startup,
- .hw_params = hdmi_dai_hw_params,
- .prepare = hdmi_dai_prepare,
- .trigger = hdmi_dai_trigger,
- .shutdown = hdmi_dai_shutdown,
+};
+static const struct snd_soc_component_driver omap_hdmi_component = {
- .name = "omapdss_hdmi",
+};
+static struct asoc_simple_card_info card_info = {
- .name = "HDMI",
- .card = "OMAPHDMI",
- .codec_dai.name = "hdmi-hifi",
+};
The above is not const. That, and the contents of the struct make me wonder, what happens if we have two HDMI instances?
I know the core driver doesn't work with multiple instances yet, but as I mentioned, it has to be done sooner or later. And on the core driver side it should be quite straightforward.
I'd rather not introduce new restrictions for that goal.
Tomi