Re: [alsa-devel] [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

Hi,

...

• res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
• sai->base = devm_ioremap_resource(&pdev->dev, res);
• if (IS_ERR(sai->base)) {

• ret = PTR_ERR(sai->base);
  

• return ret;
  
  

could be: return PTR_ERR(sai->base);

Yes，This looks better.

...

+#define FSL_SAI_DMABUF_SIZE (32 * 1024) +#define TCD_NUMBER 4 +#define EDMA_PRIO_HIGH 6

strange indentation with mixed spaces and tabs.

This will be revised in the next version.

...

+#define SAI_CR2_MSEL_MCLK3 (BIT(26)|BIT(27))

spaces around '|'?

And this too.

-- BRS, Xiubo