Re: [alsa-devel] [PATCH v4 3/8] ASoC: Intel: Boards: Machine driver for SKL+ w/ HDAudio codecs

On 24-07-18, 19:50, Pierre-Louis Bossart wrote:

+/* skl_hda_digital audio interface glue - connects codec <--> CPU */ +struct snd_soc_dai_link skl_hda_be_dai_links[HDA_DSP_MAX_BE_DAI_LINKS] = {

• /* Back End DAI links */
• {

• .name = "iDisp1",
  

• .id = 1,
  

• .cpu_dai_name = "iDisp1 Pin",
  

• .codec_name = "ehdaudio0D2",
  

• .codec_dai_name = "intel-hdmi-hifi1",
  

• .platform_name = "0000:00:1f.3",
  

you are setting this one in skl_hda_fill_card_info() so this is superfluous

• .dpcm_playback = 1,
  

• .no_pcm = 1,
  

• },
• {

• .name = "iDisp2",
  

• .id = 2,
  

• .cpu_dai_name = "iDisp2 Pin",
  

• .codec_name = "ehdaudio0D2",
  

• .codec_dai_name = "intel-hdmi-hifi2",
  

• .platform_name = "0000:00:1f.3",
  

• .dpcm_playback = 1,
  

• .no_pcm = 1,
  

• },
• {

• .name = "iDisp3",
  

• .id = 3,
  

shouldn't this be queried. not all will have 3 links

+int skl_hda_hdmi_jack_init(struct snd_soc_card *card) +{

• struct skl_hda_private *ctx = snd_soc_card_get_drvdata(card);
• struct skl_hda_hdmi_pcm *pcm;
• struct snd_soc_component *component = NULL;
• int err;
• char jack_name[NAME_SIZE];

many people prefer inverted christmas tree for these..

+static struct platform_driver skl_hda_audio = {

• .probe = skl_hda_audio_probe,
• .driver = {

• .name = "skl_hda_dsp_generic",
  

who creates this pdev, is it the board details (mach name?)