3 Jan
2011
3 Jan
'11
4:44 p.m.
On Mon, Jan 03, 2011 at 09:06:56PM +0530, Koul, Vinod wrote:
There's quite a few places where there are coding style issues, in general if your code doesn't look like other kernel code that's a problem. One of the most frequent issues was that you weren't using spaces around /* and */.
Checkpatch doesn't seem to catch these, have fixed them now. Any other inconsistency you noted which may not be detected by checkpatch
I'll point them out when I notice them; like I say this is something you should be able to check by comparing with other code.