11 Aug
2014
11 Aug
'14
1:09 p.m.
On 08/08/2014 05:29 PM, Geert Uytterhoeven wrote:
If soc_dapm_read() fails, reg_val will be uninitialized, and bogus values will be written later:
sound/soc/soc-dapm.c: In function 'snd_soc_dapm_get_enum_double': sound/soc/soc-dapm.c:2862:15: warning: 'reg_val' may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned int reg_val, val; ^
Return early on error to fix this.
Introduced by commit ce0fc93ae56e2ba50ff8c220d69e4e860e889320 ("ASoC: Add DAPM support at the component level").
Is this correct? Please review.
Yes, thanks.
Acked-by: Lars-Peter Clausen lars@metafoo.de
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be