On Wed, Aug 14, 2013 at 01:30:17PM +0800, Nicolin Chen wrote:
Hi Shwan,
On Wed, Aug 14, 2013 at 11:27:00AM +0800, Shawn Guo wrote:
I do not think we need this general compatible string. Device tree compatible should be specific.
So I should just use 'fsl,<chip>-spdif" and list all <chip>-spdif in compatible list?
I added 'fsl,fsl-spdif' just for those not-in-list chips, Vybrid for example. So you think I should add all the possible chips to the list? But what if some chip I don't know right now that also uses this spdif controller? Add them to the list later?
We only need to maintain those versions that require different programming model in the list. For example, if S/PDIF on Vybrid is completely compatible with imx6q one and uses the exactly same programming model, we do not need to maintain a compatible string for Vybrid S/PDIF at all. Instead, we only need to have something like below in Vybrid dts file, and S/PDIF driver will just work for it.
compatible = "fsl,vf600-spdif", "fsl,imx6q-spdif";
Shawn