On Fri, Jun 01, 2018 at 10:19:58AM -0500, Pierre-Louis Bossart wrote:
On 6/1/18 8:17 AM, Guenter Roeck wrote:
On 06/01/2018 03:25 AM, Mark Brown wrote:
On Thu, May 24, 2018 at 12:49:21PM -0700, Guenter Roeck wrote:
From: Guenter Roeck groeck@chromium.org
Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE DAI") introduced sound topology files version 5. Initially, this change made the topology code incompatible with v4 topology files.
No review on these from anyone at Intel?
The only actionable feedback I have seen is that the header file changes should be in uapi, which is done in patches 2 and 3.
Other than that, there was a question if this is a Linux issue or a Chromebook issue (it appears that only Chromebooks shipped with v4 configuration files). I took that as rhetorical since upstream kernels (at least v4.4 and v4.5) support topology v4 configuration files, and it should not matter which products shipped using those.
I wanted to ack this patch but the Intel validation folks asked for a couple of days to finish their tests on a variety of Chromebooks (e.g. Lars) and double-check which models used the v4 topology. There is an internal thread on all this which remains active. I don't think the feedback will be delayed beyond early next week.
Skylake-Y: caroline, cave, chell Skylake-U: asuka, lars, lili, sentry
ApolloLake (alan, electro, sand, and many more) also seem to use the same file format (or a variant of it), but I am not sure. I didn't get to testing it due to other problems with the upstream kernel which I did not have time to track down yet.
Guenter