On 11/28/2018 01:25 PM, Pavel Machek wrote:
On Wed 2018-11-28 12:38:19, Takashi Iwai wrote:
On Wed, 28 Nov 2018 12:18:06 +0100, Pali Rohár wrote:
On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote:
Looks good... except one detail: you have "tpacpi::micmute" and "dell::micmute". I know it follows "tradition", but we are trying to fix that at the moment. Laptop micmute button is a laptop micmute button, and userspace should not need to know what prefix to use depending on vendor.
I'd suggest using "sys::micmute".
I can imagine that in future some devices like keyboards would have also mute led. We already have keyboards with mute key, so it is something not unrealistic. What should be name convention for these mute leds?
Is not "sys::" prefix too generic?
Good point. I thought of "laptop::" but it's not always laptop. "builtin::"? Doesn't sound great, either.
A nice godfather is required here...
Just use sys:: :-).
laptop:: would work for me, too. (It is always laptop in the cases we are handling now, right?)
When we get a keyboard with mute led, we'll have to decide if it should be input6::mute -- because it is on keyboard, or if it is sys::mute -- because the key is expected to mute whole system.
drivers/input/input-leds.c seems to already support mute LED. It will be exposed as inputN::mute.
Documentation/leds/leds-class.txt defines LED naming pattern to devicename:color:function and "sys" does not look as something resembling device name.