Re: [alsa-devel] [RFC PATCH] ASoC: Intel: sst: Delete sst_save_shim64(); saved regs are never used

On Fri, May 26, 2017 at 7:34 PM, Douglas Anderson dianders@chromium.org wrote:

In commit 9a075265c6dc ("ASoC: Intel: sst: Remove unused function sst_restore_shim64()"), we deleted the sst_restore_shim64() since it was never used. ...but a quick look at the code shows that we should also be able to remove the sst_save_shim64() function and the structure members we were storing data in.

Note that the saving code (and the comments talking about how important it is to do the save) has been around since commit 336cfbb05edf ("ASoC: Intel: mrfld- add ACPI module").

While I like "-" statistics, the below I think should be preserved if it's repeating real registers layout.

struct sst_shim_regs64 {

•   u64 csr;
    u64 pisr;
    u64 pimr;
    u64 isrx;
    u64 isrd;
  

•   u64 imrx;
    u64 imrd;
    u64 ipcx;
    u64 ipcd;