On Fri, Jul 17, 2009 at 06:53:24PM +0800, Takashi Iwai wrote:
At Fri, 17 Jul 2009 12:46:01 +0200, I wrote:
At Fri, 17 Jul 2009 18:41:05 +0800, Guo, Chaohong wrote:
Although it does address this issue, I am not comfortable with this fixing. It seems more like a workaround than fix.
No, it's rather for catching a bug. This is definitely neither "workaround" nor "fix".
BTW, I fixed the patch again as below.
Takashi
From 82e1b804b03defe46fb69ffd2c8b19e6649bcb0d Mon Sep 17 00:00:00 2001
From: Takashi Iwai tiwai@suse.de Date: Fri, 17 Jul 2009 12:47:34 +0200 Subject: [PATCH] ALSA: hda - Fix the previous sanity check in make_codec_cmd()
The newly added sanity-check for a codec verb can be better written with logical ORs. Also, the parameter can be more than 8bit.
Ah OK, thanks for the fix!
Thanks, Fengguang