On Wed, Mar 21, 2012 at 10:11:20PM +0530, Ashish Chavan wrote:
On Wed, 2012-03-21 at 15:56 +0000, Mark Brown wrote:
This is writing to page register. SPI register space is divided in to two pages. Registers from 0x01 to 0x80 fall in to first page. If we want to write to any register above 0x80, first we need to set page register with PAGE1. May be I should put comments to make it obvious.
You also need to make sure that the register cache doesn't get confused.
/* unlock */ regmap_write(da7210->regmap, DA7210_A_HID_UNLOCK, 0x8B); @@ -1035,6 +1056,10 @@ static int da7210_probe(struct snd_soc_codec *codec) regmap_write(da7210->regmap, DA7210_A_HID_UNLOCK, 0x00); regmap_write(da7210->regmap, DA7210_A_TEST_UNLOCK, 0x00);
I also note that you've not yet updated this to use a regmap patch as was previously requested.
Actually I don't have enough details about the problem that you mentioned with this. I am waiting for inputs from some body else. Can
...and didn't bother asking any questions so it's unlikely anyone will say anything...
you please elaborate the problem if you have details? so that I can correct it.
What is unclear in the previous feedback? You should be converting this to use a regmap patch...