On Wed, Nov 19, 2014 at 08:36:08PM +0800, Zidan Wang wrote:
wm8960 codec has a wm8960_data struct which has two fields shared_lrclk and capless. The wm8960_data is get from platform_data and it is reasonable to set it from device tree when platform_data is null. And when shared_lrclk is set, LRCM will be enabled. But the following software reset in wm8960_probe will reset it to the default state. So LRCM operation should after software reset.
Signed-off-by: Zidan Wang b50113@freescale.com
sound/soc/codecs/wm8960.c | 49 ++++++++++++++++++++++++++++++----------------- 1 file changed, 31 insertions(+), 18 deletions(-)
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 4dc4e85..1d56c90 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -1038,6 +1055,7 @@ static int wm8960_i2c_probe(struct i2c_client *i2c,
wm8960 = devm_kzalloc(&i2c->dev, sizeof(struct wm8960_priv), GFP_KERNEL);
- if (wm8960 == NULL) return -ENOMEM;
Extra blank line accidentally being added here.
Also I would probably make the shifting of the shared_lrclk handling a different patch as that is a bug fix and shouldn't really be tided into a patch adding DT bindings.
As pointed out this will need a corresponding DT documentaion patch, but apart from those things looks good to me.
Thanks, Charles