Re: [PATCH v6 2/2] ASoC: cs35l41: Add bindings for CS35L41

On 9/6/21 4:43 AM, Charles Keepax wrote:

On Fri, Sep 03, 2021 at 04:26:59PM -0500, David Rhodes wrote:

...

• cirrus,classh-bst-max-limit:
• description:

•  Value set to the BST_CTL_LIM_EN field.
  

•  A value of 1 will limit the Class-H voltage to the value in the
  

•  'boost-ctl-millivolt' property.
  

•  0 = No Class-H limit (default)
  

•  1 = Class-H limited to 'boost-ctl-millivolt' value
  

• $ref: "/schemas/types.yaml#/definitions/uint32"
• minimum: 0
• maximum: 1

There is no boost-ctl-millivolt property however. Apart from tidying up that loose end I think the series looks ok to me though.

Thanks, Charles

Yes, I missed this while moving the boost properties. classh-bst-max-limit should be removed since it doesn't work without boost-ctl-millivolt. boost-peak-milliamp is more appropriate for limiting the boost, and will remain a required property.

Thanks, David