Re: [alsa-devel] [PATCH] Emit an error message when dlopen fails.

On Wed, 22 Nov 2017 02:09:44 +0100, Takashi Sakamoto wrote:

Hi,

On Nov 22 2017 07:12, Cedric Roux wrote:

...

Signed-off-by: Cedric Roux sed@free.fr

src/dlmisc.c | 4 ++++ 1 file changed, 4 insertions(+)

diff --git src/dlmisc.c src/dlmisc.c index f154ebd0..9e8e401e 100644 --- src/dlmisc.c +++ src/dlmisc.c @@ -81,10 +81,14 @@ void *snd_dlopen(const char *name, int mode) strcat(filename, "/"); strcat(filename, name); handle = dlopen(filename, mode);

• if (!handle)
  

• 	SNDERR("snd_dlopen: %s: %s", filename, dlerror());
  

  free(filename); } if (!handle) handle = dlopen(name, mode);
• if (!handle)

• SNDERR("snd_dlopen: %s: %s", name, dlerror());
  

  return handle; #else return NULL;

In my opinion, this patch is preferable, however it can always generate superfluous error messages when handling hook configuration on 'alsa.conf'.

It can use SNDMSG() macro instead. Then the message appears only when the debug is activated via $LIBASOUND_DEBUG.

Takashi