Hi,
On 03-01-18 11:50, Mark Brown wrote:
On Tue, Jan 02, 2018 at 07:53:09PM +0100, Hans de Goede wrote:
Register "micbias1" and "micbias2" to supply widegts as modern drivers do.
- SND_SOC_DAPM_MICBIAS("micbias1", RT5645_PWR_ANLG2,
RT5645_PWR_MB1_BIT, 0),- SND_SOC_DAPM_MICBIAS("micbias2", RT5645_PWR_ANLG2,
RT5645_PWR_MB2_BIT, 0),
- SND_SOC_DAPM_SUPPLY("micbias1", RT5645_PWR_ANLG2,
RT5645_PWR_MB1_BIT, 0, NULL, 0),- SND_SOC_DAPM_SUPPLY("micbias2", RT5645_PWR_ANLG2,
RT5645_PWR_MB2_BIT, 0, NULL, 0),This is a good change to make but we have machines with the rt5645, are we sure none of them use microphones? The two widget types work differently so it needs some checking and possibly machine driver updates to convert.
Right, we have existing machines with a rt5645 and an internal analog mic, but those have been broken sofar (I can confirm this for Cherry Trail based devices, I assume it applies elsewhere) because without the next patch in this series we were never actually enabling micbias. So this change should be fine as analog mic support has been broken sofar anyways AFAIK.
Regards,
Hans