@@ -196,6 +201,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_baytrail_machines[] = { }, { .id = "10EC5682",
.id_alt = &rt5682s_hp,So this is only useful if there actually are any BYT devices using the "RTL5682" ACPI HID, the 100+ BYT/CHT DSDTs which I've gather over time say there aren't any.
Actually there also aren't any using the non alt "10EC5682" ACPI HID either...
Bard Liao, you added this in commit f70abd75b7c6 ("ASoC: Intel: add sof-rt5682 machine driver") but I wonder how useful this is. I guess it may be available as (and tested on?) some dev-kit.
But I don't think there us any hardware out there in the wild using this ?
In the past we used this configuration for SOF CI tests with the MinnowBoard + an RT5682 eval board. We gradually fried most boards and no longer check this capability for each SOF PR.
So I would agree we can avoid changing anything for BYT/CHT and possibly APL, it'd be an untested configuration.
in other words, let's add this compatible/alt_id for platforms where we know it'll be used.