27 Jan
2014
27 Jan
'14
4:15 p.m.
On Mon, Jan 27, 2014 at 01:03:10PM +0100, Markus Pargmann wrote:
- aic32x4->supply_ldo = devm_regulator_get_optional(dev, "ldoin");
- aic32x4->supply_iov = devm_regulator_get_optional(dev, "iov");
- aic32x4->supply_dv = devm_regulator_get_optional(dev, "dv");
- aic32x4->supply_av = devm_regulator_get_optional(dev, "av");
These shouldn't be optional, it seems unlikely that the device is going to work without power. This will also be broken for probe deferral since the code will just ignore errors so if the error is -EPROBE_DEFER it'll not actually defer.
Just use the normal bulk functions, as Fabio said this will be simpler too, and there should be code to disable on device removal at least (ideally also on suspend and resume, and while the device is idle if it doesn't have slow startup times).