Re: [alsa-devel] [PATCH v4 9/9] ASoC: add audio-graph-card support

21 Mar 2017

      Hi Rob
Thank you for your review
...
...

  if (rcpu_ep != cpu_ep) {

          dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n",

                  cpu_ep->name, codec_ep->name, rcpu_ep->name);

          return -EINVAL;

  }

We should have this check in dtc rather than the kernel.
We can remove this if dtc could support it
...
...

  while ((np = of_parse_phandle(node, "dais", idx))) {

of_for_each_phandle
(snip)
...
...

  if (of_get_property(node, "dais", NULL)) {

          while (of_parse_phandle(node, "dais", count))

of_for_each_phandle
Thanks. will use it
...
...

                  count++;

  } else {

          count = 1;

This should be an error or 0, right?
Yes, thanks. will do
Best regards
---
Kuninori Morimoto